-
-
Notifications
You must be signed in to change notification settings - Fork 827
Remove unused code left over from the old search #8947
Remove unused code left over from the old search #8947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the Runtime filtering stuff can be removed also, including stuff like
matrix-react-sdk/src/stores/room-list/RoomListStore.ts
Lines 564 to 571 in 2a396a4
this.filterConditions.push(filter); | |
// Runtime filters with spaces disable prefiltering for the search all spaces feature. | |
// this has to be awaited so that `setKnownRooms` is called in time for the `addFilterCondition` below | |
// this way the runtime filters are only evaluated on one dataset and not both. | |
await this.recalculatePrefiltering(); | |
if (this.algorithm) { | |
this.algorithm.addFilterCondition(filter); | |
} |
Are you sure? It looks like that’s used for filtering by space |
Spaces use Prefiltering, not Runtime filtering, that else clause will never be entered to my knowledge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is FilterKind used any more? Or at least is Runtime filterkind used anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all the filter handling in Algorithm.ts is also now dead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me, thanks!
Type: Task
Closes: element-hq/element-web#22696
This change is marked as an internal change (Task), so will not be included in the changelog.