Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove unused code left over from the old search #8947

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

justjanne
Copy link
Contributor

@justjanne justjanne commented Jun 30, 2022

Type: Task
Closes: element-hq/element-web#22696


This change is marked as an internal change (Task), so will not be included in the changelog.

@justjanne justjanne added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 30, 2022
@justjanne justjanne requested a review from a team as a code owner June 30, 2022 10:57
@justjanne justjanne requested review from germain-gg, dbkr and t3chguy June 30, 2022 10:57
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the Runtime filtering stuff can be removed also, including stuff like

this.filterConditions.push(filter);
// Runtime filters with spaces disable prefiltering for the search all spaces feature.
// this has to be awaited so that `setKnownRooms` is called in time for the `addFilterCondition` below
// this way the runtime filters are only evaluated on one dataset and not both.
await this.recalculatePrefiltering();
if (this.algorithm) {
this.algorithm.addFilterCondition(filter);
}

@justjanne
Copy link
Contributor Author

I think all the Runtime filtering stuff can be removed also, including stuff like

Are you sure? It looks like that’s used for filtering by space

@t3chguy
Copy link
Member

t3chguy commented Jun 30, 2022

Spaces use Prefiltering, not Runtime filtering, that else clause will never be entered to my knowledge

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is FilterKind used any more? Or at least is Runtime filterkind used anymore?

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all the filter handling in Algorithm.ts is also now dead

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, thanks!

@justjanne justjanne merged commit 328d7ea into develop Jun 30, 2022
@justjanne justjanne deleted the justjanne/task/22696-remove-unused-search-code branch June 30, 2022 15:14
@luixxiul luixxiul mentioned this pull request May 1, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused code left over from the old search
2 participants