This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 831
Write tests for message right-click context menu #8532
Merged
SimonBrandner
merged 11 commits into
matrix-org:develop
from
SimonBrandner:SimonBrandner/task/right-click-tests
May 11, 2022
Merged
Write tests for message right-click context menu #8532
SimonBrandner
merged 11 commits into
matrix-org:develop
from
SimonBrandner:SimonBrandner/task/right-click-tests
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBrandner
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
May 8, 2022
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
May 9, 2022 14:46
8749f4f
to
519ca02
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
May 9, 2022 17:10
519ca02
to
acc4bed
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
May 9, 2022 17:16
acc4bed
to
67e4b45
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
May 9, 2022 19:37
67e4b45
to
bc5a837
Compare
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
May 10, 2022 04:27
bc5a837
to
9ba60f6
Compare
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
SimonBrandner/task/right-click-tests
branch
from
May 10, 2022 16:27
9ba60f6
to
b73dd49
Compare
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
robintown
suggested changes
May 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have more coverage of this 👍
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
Oops, you get double the reviews :D |
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Sorry for quite a few dumb mistakes in this one... |
Signed-off-by: Šimon Brandner <[email protected]>
test/components/views/context_menus/MessageContextMenu-test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
…sk/right-click-tests
kerryarchibald
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this!
robintown
approved these changes
May 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#21815
Based on #8527
This change is marked as an internal change (Task), so will not be included in the changelog.