Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Write tests for message right-click context menu #8532

Conversation

SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented May 8, 2022

Fixes element-hq/element-web#21815
Based on #8527


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner SimonBrandner force-pushed the SimonBrandner/task/right-click-tests branch from 9ba60f6 to b73dd49 Compare May 10, 2022 16:27
@SimonBrandner SimonBrandner marked this pull request as ready for review May 10, 2022 16:49
@SimonBrandner SimonBrandner requested a review from a team as a code owner May 10, 2022 16:49
Copy link
Member

@robintown robintown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have more coverage of this 👍

@robintown
Copy link
Member

Oops, you get double the reviews :D

Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
@SimonBrandner
Copy link
Contributor Author

Sorry for quite a few dumb mistakes in this one...

@SimonBrandner SimonBrandner requested a review from robintown May 11, 2022 13:22
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@SimonBrandner SimonBrandner merged commit 5348572 into matrix-org:develop May 11, 2022
@SimonBrandner SimonBrandner deleted the SimonBrandner/task/right-click-tests branch May 11, 2022 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for message right-click context menu
3 participants