This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 830
Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent #8485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or mx_TextualEvent - IRC layout: unspecified - Modern layout: $font-22px (with _GroupLayout.scss) - Bubble layout: $font-18px (with _EventBubbleTile.scss) Signed-off-by: Suguru Hirahara <[email protected]>
github-actions
bot
added
the
T-Defect
Bugs, crashes, hangs, vulnerabilities, or other reported problems
label
May 3, 2022
t3chguy
approved these changes
May 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me, thanks!
please pull in latest develop to get the tests passing :) |
@t3chguy done! |
su-ex
added a commit
to SchildiChat/element-desktop
that referenced
this pull request
May 28, 2022
* Go to space landing page when clicking on a selected space ([\#6442](matrix-org/matrix-react-sdk#6442)). Fixes element-hq/element-web#20296. * Fall back to untranslated string rather than showing missing translation error ([\#8609](matrix-org/matrix-react-sdk#8609)). * Show file name and size on images on hover ([\#6511](matrix-org/matrix-react-sdk#6511)). Fixes element-hq/element-web#18197. * Iterate on search results for message bubbles ([\#7047](matrix-org/matrix-react-sdk#7047)). Fixes element-hq/element-web#20315. * registration: redesign email verification page ([\#8554](matrix-org/matrix-react-sdk#8554)). Fixes element-hq/element-web#21984. * Show full thread message in hover title on thread summary ([\#8568](matrix-org/matrix-react-sdk#8568)). Fixes element-hq/element-web#22037. * Tweak video rooms copy ([\#8582](matrix-org/matrix-react-sdk#8582)). Fixes element-hq/element-web#22176. * Live location share - beacon tooltip in maximised view ([\#8572](matrix-org/matrix-react-sdk#8572)). * Add dialog to navigate long room topics ([\#8517](matrix-org/matrix-react-sdk#8517)). Fixes element-hq/element-web#9623. * Change spaceroomfacepile tooltip if memberlist is shown ([\#8571](matrix-org/matrix-react-sdk#8571)). Fixes element-hq/element-web#17406. * Improve message editing UI ([\#8483](matrix-org/matrix-react-sdk#8483)). Fixes element-hq/element-web#9752 and element-hq/element-web#22108. * Make date changes more obvious ([\#6410](matrix-org/matrix-react-sdk#6410)). Fixes element-hq/element-web#16221. * Enable forwarding static locations ([\#8553](matrix-org/matrix-react-sdk#8553)). * Log `TimelinePanel` debugging info when opening the bug report modal ([\#8502](matrix-org/matrix-react-sdk#8502)). * Improve welcome screen, add opt-out analytics ([\#8474](matrix-org/matrix-react-sdk#8474)). Fixes element-hq/element-web#21946. * Converting selected text to MD link when pasting a URL ([\#8242](matrix-org/matrix-react-sdk#8242)). Fixes element-hq/element-web#21634. Contributed by @Sinharitik589. * Support Inter on custom themes ([\#8399](matrix-org/matrix-react-sdk#8399)). Fixes element-hq/element-web#16293. * Add a `Copy link` button to the right-click message context-menu labs feature ([\#8527](matrix-org/matrix-react-sdk#8527)). * Move widget screenshots labs flag to devtools ([\#8522](matrix-org/matrix-react-sdk#8522)). * Remove some labs features which don't get used or create maintenance burden: custom status, multiple integration managers, and do not disturb ([\#8521](matrix-org/matrix-react-sdk#8521)). * Add a way to toggle `ScrollPanel` and `TimelinePanel` debug logs ([\#8513](matrix-org/matrix-react-sdk#8513)). * Spaces: remove blue beta dot ([\#8511](matrix-org/matrix-react-sdk#8511)). Fixes element-hq/element-web#22061. * Order new search dialog results by recency ([\#8444](matrix-org/matrix-react-sdk#8444)). * Improve pills ([\#6398](matrix-org/matrix-react-sdk#6398)). Fixes element-hq/element-web#16948 and element-hq/element-web#21281. * Add a way to maximize/pin widget from the PiP view ([\#7672](matrix-org/matrix-react-sdk#7672)). Fixes element-hq/element-web#20723. * Iterate video room designs in labs ([\#8499](matrix-org/matrix-react-sdk#8499)). * Improve UI/UX in calls ([\#7791](matrix-org/matrix-react-sdk#7791)). Fixes element-hq/element-web#19937. * Add ability to change audio and video devices during a call ([\#7173](matrix-org/matrix-react-sdk#7173)). Fixes element-hq/element-web#15595. * Fix video rooms sometimes connecting muted when they shouldn't ([\#22125](element-hq/element-web#22125)). * Avoid flashing the 'join conference' button at the user in video rooms ([\#22120](element-hq/element-web#22120)). * Fully close Jitsi conferences on errors ([\#22060](element-hq/element-web#22060)). * Fix click behavior of notification badges on spaces ([\#8627](matrix-org/matrix-react-sdk#8627)). Fixes element-hq/element-web#22241. * Add missing return values in Read Receipt animation code ([\#8625](matrix-org/matrix-react-sdk#8625)). Fixes element-hq/element-web#22175. * Fix 'continue' button not working after accepting identity server terms of service ([\#8619](matrix-org/matrix-react-sdk#8619)). Fixes element-hq/element-web#20003. * Proactively fix stuck devices in video rooms ([\#8587](matrix-org/matrix-react-sdk#8587)). Fixes element-hq/element-web#22131. * Fix position of the message action bar on left side bubbles ([\#8398](matrix-org/matrix-react-sdk#8398)). Fixes element-hq/element-web#21879. Contributed by @luixxiul. * Fix edge case thread summaries around events without a msgtype ([\#8576](matrix-org/matrix-react-sdk#8576)). * Fix favourites metaspace not updating ([\#8594](matrix-org/matrix-react-sdk#8594)). Fixes element-hq/element-web#22156. * Stop spaces from displaying as rooms in new breadcrumbs ([\#8595](matrix-org/matrix-react-sdk#8595)). Fixes element-hq/element-web#22165. * Fix avatar position of hidden event on ThreadView ([\#8592](matrix-org/matrix-react-sdk#8592)). Fixes element-hq/element-web#22199. Contributed by @luixxiul. * Fix MessageTimestamp position next to redacted messages on IRC/modern layout ([\#8591](matrix-org/matrix-react-sdk#8591)). Fixes element-hq/element-web#22181. Contributed by @luixxiul. * Fix padding of messages in threads ([\#8574](matrix-org/matrix-react-sdk#8574)). Contributed by @luixxiul. * Enable overflow of hidden events content ([\#8585](matrix-org/matrix-react-sdk#8585)). Fixes element-hq/element-web#22187. Contributed by @luixxiul. * Increase composer line height to avoid cutting off emoji ([\#8583](matrix-org/matrix-react-sdk#8583)). Fixes element-hq/element-web#22170. * Don't consider threads for breaking continuation until actually created ([\#8581](matrix-org/matrix-react-sdk#8581)). Fixes element-hq/element-web#22164. * Fix displaying hidden events on threads ([\#8555](matrix-org/matrix-react-sdk#8555)). Fixes element-hq/element-web#22058. Contributed by @luixxiul. * Fix button width and align 絵文字 (emoji) on the user panel ([\#8562](matrix-org/matrix-react-sdk#8562)). Fixes element-hq/element-web#22142. Contributed by @luixxiul. * Standardise the margin for settings tabs ([\#7963](matrix-org/matrix-react-sdk#7963)). Fixes element-hq/element-web#20767. Contributed by @yuktea. * Fix room history not being visible even if we have historical keys ([\#8563](matrix-org/matrix-react-sdk#8563)). Fixes element-hq/element-web#16983. * Fix oblong avatars in video room lobbies ([\#8565](matrix-org/matrix-react-sdk#8565)). * Update thread summary when latest event gets decrypted ([\#8564](matrix-org/matrix-react-sdk#8564)). Fixes element-hq/element-web#22151. * Fix codepath which can wrongly cause automatic space switch from all rooms ([\#8560](matrix-org/matrix-react-sdk#8560)). Fixes element-hq/element-web#21373. * Fix effect of URL preview toggle not updating live ([\#8561](matrix-org/matrix-react-sdk#8561)). Fixes element-hq/element-web#22148. * Fix visual bugs on AccessSecretStorageDialog ([\#8160](matrix-org/matrix-react-sdk#8160)). Fixes element-hq/element-web#19426. Contributed by @luixxiul. * Fix the width bounce of the clock on the AudioPlayer ([\#8320](matrix-org/matrix-react-sdk#8320)). Fixes element-hq/element-web#21788. Contributed by @luixxiul. * Hide the verification left stroke only on the thread list ([\#8525](matrix-org/matrix-react-sdk#8525)). Fixes element-hq/element-web#22132. Contributed by @luixxiul. * Hide recently_viewed dropdown when other modal opens ([\#8538](matrix-org/matrix-react-sdk#8538)). Contributed by @yaya-usman. * Only jump to date after pressing the 'go' button ([\#8548](matrix-org/matrix-react-sdk#8548)). Fixes element-hq/element-web#20799. * Fix download button not working on events that were decrypted too late ([\#8556](matrix-org/matrix-react-sdk#8556)). Fixes element-hq/element-web#19427. * Align thread summary button with bubble messages on the left side ([\#8388](matrix-org/matrix-react-sdk#8388)). Fixes element-hq/element-web#21873. Contributed by @luixxiul. * Fix unresponsive notification toggles ([\#8549](matrix-org/matrix-react-sdk#8549)). Fixes element-hq/element-web#22109. * Set color-scheme property in themes ([\#8547](matrix-org/matrix-react-sdk#8547)). Fixes element-hq/element-web#22124. * Improve the styling of error messages during search initialization. ([\#6899](matrix-org/matrix-react-sdk#6899)). Fixes element-hq/element-web#19245 and element-hq/element-web#18164. Contributed by @KalleStruik. * Don't leave button tooltips open when closing modals ([\#8546](matrix-org/matrix-react-sdk#8546)). Fixes element-hq/element-web#22121. * update matrix-analytics-events ([\#8543](matrix-org/matrix-react-sdk#8543)). * Handle Jitsi Meet crashes more gracefully ([\#8541](matrix-org/matrix-react-sdk#8541)). * Fix regression around pasting links ([\#8537](matrix-org/matrix-react-sdk#8537)). Fixes element-hq/element-web#22117. * Fixes suggested room not ellipsized on shrinking ([\#8536](matrix-org/matrix-react-sdk#8536)). Contributed by @yaya-usman. * Add global spacing between display name and location body ([\#8523](matrix-org/matrix-react-sdk#8523)). Fixes element-hq/element-web#22111. Contributed by @luixxiul. * Add box-shadow to the reply preview on the main (left) panel only ([\#8397](matrix-org/matrix-react-sdk#8397)). Fixes element-hq/element-web#21894. Contributed by @luixxiul. * Set line-height: 1 to RedactedBody inside GenericEventListSummary for IRC/modern layout ([\#8529](matrix-org/matrix-react-sdk#8529)). Fixes element-hq/element-web#22112. Contributed by @luixxiul. * Fix position of timestamp on the chat panel in IRC layout and message edits history modal window ([\#8464](matrix-org/matrix-react-sdk#8464)). Fixes element-hq/element-web#22011 and element-hq/element-web#22014. Contributed by @luixxiul. * Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent ([\#8485](matrix-org/matrix-react-sdk#8485)). Fixes element-hq/element-web#22041. Contributed by @luixxiul. * Set the same margin to the right side of NewRoomIntro on TimelineCard ([\#8453](matrix-org/matrix-react-sdk#8453)). Contributed by @luixxiul. * Remove duplicate tooltip from user pills ([\#8512](matrix-org/matrix-react-sdk#8512)). * Set max-width for MLocationBody and MLocationBody_map by default ([\#8519](matrix-org/matrix-react-sdk#8519)). Fixes element-hq/element-web#21983. Contributed by @luixxiul. * Simplify ReplyPreview UI implementation ([\#8516](matrix-org/matrix-react-sdk#8516)). Fixes element-hq/element-web#22091. Contributed by @luixxiul. * Fix thread summary overflow on narrow message panel on bubble message layout ([\#8520](matrix-org/matrix-react-sdk#8520)). Fixes element-hq/element-web#22097. Contributed by @luixxiul. * Live location sharing - refresh beacon timers on tab becoming active ([\#8515](matrix-org/matrix-react-sdk#8515)). * Enlarge emoji again ([\#8509](matrix-org/matrix-react-sdk#8509)). Fixes element-hq/element-web#22086. * Order receipts with the most recent on the right ([\#8506](matrix-org/matrix-react-sdk#8506)). Fixes element-hq/element-web#22044. * Disconnect from video rooms when leaving ([\#8500](matrix-org/matrix-react-sdk#8500)). * Fix soft crash around threads when room isn't yet in store ([\#8496](matrix-org/matrix-react-sdk#8496)). Fixes element-hq/element-web#22047. * Fix reading of cached room device setting values ([\#8491](matrix-org/matrix-react-sdk#8491)). * Add loading spinners to threads panels ([\#8490](matrix-org/matrix-react-sdk#8490)). Fixes element-hq/element-web#21335. * Fix forwarding UI papercuts ([\#8482](matrix-org/matrix-react-sdk#8482)). Fixes element-hq/element-web#17616.
su-ex
added a commit
to SchildiChat/matrix-react-sdk
that referenced
this pull request
May 28, 2022
* Go to space landing page when clicking on a selected space ([\matrix-org#6442](matrix-org#6442)). Fixes element-hq/element-web#20296. * Fall back to untranslated string rather than showing missing translation error ([\matrix-org#8609](matrix-org#8609)). * Show file name and size on images on hover ([\matrix-org#6511](matrix-org#6511)). Fixes element-hq/element-web#18197. * Iterate on search results for message bubbles ([\matrix-org#7047](matrix-org#7047)). Fixes element-hq/element-web#20315. * registration: redesign email verification page ([\matrix-org#8554](matrix-org#8554)). Fixes element-hq/element-web#21984. * Show full thread message in hover title on thread summary ([\matrix-org#8568](matrix-org#8568)). Fixes element-hq/element-web#22037. * Tweak video rooms copy ([\matrix-org#8582](matrix-org#8582)). Fixes element-hq/element-web#22176. * Live location share - beacon tooltip in maximised view ([\matrix-org#8572](matrix-org#8572)). * Add dialog to navigate long room topics ([\matrix-org#8517](matrix-org#8517)). Fixes element-hq/element-web#9623. * Change spaceroomfacepile tooltip if memberlist is shown ([\matrix-org#8571](matrix-org#8571)). Fixes element-hq/element-web#17406. * Improve message editing UI ([\matrix-org#8483](matrix-org#8483)). Fixes element-hq/element-web#9752 and element-hq/element-web#22108. * Make date changes more obvious ([\matrix-org#6410](matrix-org#6410)). Fixes element-hq/element-web#16221. * Enable forwarding static locations ([\matrix-org#8553](matrix-org#8553)). * Log `TimelinePanel` debugging info when opening the bug report modal ([\matrix-org#8502](matrix-org#8502)). * Improve welcome screen, add opt-out analytics ([\matrix-org#8474](matrix-org#8474)). Fixes element-hq/element-web#21946. * Converting selected text to MD link when pasting a URL ([\matrix-org#8242](matrix-org#8242)). Fixes element-hq/element-web#21634. Contributed by @Sinharitik589. * Support Inter on custom themes ([\matrix-org#8399](matrix-org#8399)). Fixes element-hq/element-web#16293. * Add a `Copy link` button to the right-click message context-menu labs feature ([\matrix-org#8527](matrix-org#8527)). * Move widget screenshots labs flag to devtools ([\matrix-org#8522](matrix-org#8522)). * Remove some labs features which don't get used or create maintenance burden: custom status, multiple integration managers, and do not disturb ([\matrix-org#8521](matrix-org#8521)). * Add a way to toggle `ScrollPanel` and `TimelinePanel` debug logs ([\matrix-org#8513](matrix-org#8513)). * Spaces: remove blue beta dot ([\matrix-org#8511](matrix-org#8511)). Fixes element-hq/element-web#22061. * Order new search dialog results by recency ([\matrix-org#8444](matrix-org#8444)). * Improve pills ([\matrix-org#6398](matrix-org#6398)). Fixes element-hq/element-web#16948 and element-hq/element-web#21281. * Add a way to maximize/pin widget from the PiP view ([\matrix-org#7672](matrix-org#7672)). Fixes element-hq/element-web#20723. * Iterate video room designs in labs ([\matrix-org#8499](matrix-org#8499)). * Improve UI/UX in calls ([\matrix-org#7791](matrix-org#7791)). Fixes element-hq/element-web#19937. * Add ability to change audio and video devices during a call ([\matrix-org#7173](matrix-org#7173)). Fixes element-hq/element-web#15595. * Fix click behavior of notification badges on spaces ([\matrix-org#8627](matrix-org#8627)). Fixes element-hq/element-web#22241. * Add missing return values in Read Receipt animation code ([\matrix-org#8625](matrix-org#8625)). Fixes element-hq/element-web#22175. * Fix 'continue' button not working after accepting identity server terms of service ([\matrix-org#8619](matrix-org#8619)). Fixes element-hq/element-web#20003. * Proactively fix stuck devices in video rooms ([\matrix-org#8587](matrix-org#8587)). Fixes element-hq/element-web#22131. * Fix position of the message action bar on left side bubbles ([\matrix-org#8398](matrix-org#8398)). Fixes element-hq/element-web#21879. Contributed by @luixxiul. * Fix edge case thread summaries around events without a msgtype ([\matrix-org#8576](matrix-org#8576)). * Fix favourites metaspace not updating ([\matrix-org#8594](matrix-org#8594)). Fixes element-hq/element-web#22156. * Stop spaces from displaying as rooms in new breadcrumbs ([\matrix-org#8595](matrix-org#8595)). Fixes element-hq/element-web#22165. * Fix avatar position of hidden event on ThreadView ([\matrix-org#8592](matrix-org#8592)). Fixes element-hq/element-web#22199. Contributed by @luixxiul. * Fix MessageTimestamp position next to redacted messages on IRC/modern layout ([\matrix-org#8591](matrix-org#8591)). Fixes element-hq/element-web#22181. Contributed by @luixxiul. * Fix padding of messages in threads ([\matrix-org#8574](matrix-org#8574)). Contributed by @luixxiul. * Enable overflow of hidden events content ([\matrix-org#8585](matrix-org#8585)). Fixes element-hq/element-web#22187. Contributed by @luixxiul. * Increase composer line height to avoid cutting off emoji ([\matrix-org#8583](matrix-org#8583)). Fixes element-hq/element-web#22170. * Don't consider threads for breaking continuation until actually created ([\matrix-org#8581](matrix-org#8581)). Fixes element-hq/element-web#22164. * Fix displaying hidden events on threads ([\matrix-org#8555](matrix-org#8555)). Fixes element-hq/element-web#22058. Contributed by @luixxiul. * Fix button width and align 絵文字 (emoji) on the user panel ([\matrix-org#8562](matrix-org#8562)). Fixes element-hq/element-web#22142. Contributed by @luixxiul. * Standardise the margin for settings tabs ([\matrix-org#7963](matrix-org#7963)). Fixes element-hq/element-web#20767. Contributed by @yuktea. * Fix room history not being visible even if we have historical keys ([\matrix-org#8563](matrix-org#8563)). Fixes element-hq/element-web#16983. * Fix oblong avatars in video room lobbies ([\matrix-org#8565](matrix-org#8565)). * Update thread summary when latest event gets decrypted ([\matrix-org#8564](matrix-org#8564)). Fixes element-hq/element-web#22151. * Fix codepath which can wrongly cause automatic space switch from all rooms ([\matrix-org#8560](matrix-org#8560)). Fixes element-hq/element-web#21373. * Fix effect of URL preview toggle not updating live ([\matrix-org#8561](matrix-org#8561)). Fixes element-hq/element-web#22148. * Fix visual bugs on AccessSecretStorageDialog ([\matrix-org#8160](matrix-org#8160)). Fixes element-hq/element-web#19426. Contributed by @luixxiul. * Fix the width bounce of the clock on the AudioPlayer ([\matrix-org#8320](matrix-org#8320)). Fixes element-hq/element-web#21788. Contributed by @luixxiul. * Hide the verification left stroke only on the thread list ([\matrix-org#8525](matrix-org#8525)). Fixes element-hq/element-web#22132. Contributed by @luixxiul. * Hide recently_viewed dropdown when other modal opens ([\matrix-org#8538](matrix-org#8538)). Contributed by @yaya-usman. * Only jump to date after pressing the 'go' button ([\matrix-org#8548](matrix-org#8548)). Fixes element-hq/element-web#20799. * Fix download button not working on events that were decrypted too late ([\matrix-org#8556](matrix-org#8556)). Fixes element-hq/element-web#19427. * Align thread summary button with bubble messages on the left side ([\matrix-org#8388](matrix-org#8388)). Fixes element-hq/element-web#21873. Contributed by @luixxiul. * Fix unresponsive notification toggles ([\matrix-org#8549](matrix-org#8549)). Fixes element-hq/element-web#22109. * Set color-scheme property in themes ([\matrix-org#8547](matrix-org#8547)). Fixes element-hq/element-web#22124. * Improve the styling of error messages during search initialization. ([\matrix-org#6899](matrix-org#6899)). Fixes element-hq/element-web#19245 and element-hq/element-web#18164. Contributed by @KalleStruik. * Don't leave button tooltips open when closing modals ([\matrix-org#8546](matrix-org#8546)). Fixes element-hq/element-web#22121. * update matrix-analytics-events ([\matrix-org#8543](matrix-org#8543)). * Handle Jitsi Meet crashes more gracefully ([\matrix-org#8541](matrix-org#8541)). * Fix regression around pasting links ([\matrix-org#8537](matrix-org#8537)). Fixes element-hq/element-web#22117. * Fixes suggested room not ellipsized on shrinking ([\matrix-org#8536](matrix-org#8536)). Contributed by @yaya-usman. * Add global spacing between display name and location body ([\matrix-org#8523](matrix-org#8523)). Fixes element-hq/element-web#22111. Contributed by @luixxiul. * Add box-shadow to the reply preview on the main (left) panel only ([\matrix-org#8397](matrix-org#8397)). Fixes element-hq/element-web#21894. Contributed by @luixxiul. * Set line-height: 1 to RedactedBody inside GenericEventListSummary for IRC/modern layout ([\matrix-org#8529](matrix-org#8529)). Fixes element-hq/element-web#22112. Contributed by @luixxiul. * Fix position of timestamp on the chat panel in IRC layout and message edits history modal window ([\matrix-org#8464](matrix-org#8464)). Fixes element-hq/element-web#22011 and element-hq/element-web#22014. Contributed by @luixxiul. * Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent ([\matrix-org#8485](matrix-org#8485)). Fixes element-hq/element-web#22041. Contributed by @luixxiul. * Set the same margin to the right side of NewRoomIntro on TimelineCard ([\matrix-org#8453](matrix-org#8453)). Contributed by @luixxiul. * Remove duplicate tooltip from user pills ([\matrix-org#8512](matrix-org#8512)). * Set max-width for MLocationBody and MLocationBody_map by default ([\matrix-org#8519](matrix-org#8519)). Fixes element-hq/element-web#21983. Contributed by @luixxiul. * Simplify ReplyPreview UI implementation ([\matrix-org#8516](matrix-org#8516)). Fixes element-hq/element-web#22091. Contributed by @luixxiul. * Fix thread summary overflow on narrow message panel on bubble message layout ([\matrix-org#8520](matrix-org#8520)). Fixes element-hq/element-web#22097. Contributed by @luixxiul. * Live location sharing - refresh beacon timers on tab becoming active ([\matrix-org#8515](matrix-org#8515)). * Enlarge emoji again ([\matrix-org#8509](matrix-org#8509)). Fixes element-hq/element-web#22086. * Order receipts with the most recent on the right ([\matrix-org#8506](matrix-org#8506)). Fixes element-hq/element-web#22044. * Disconnect from video rooms when leaving ([\matrix-org#8500](matrix-org#8500)). * Fix soft crash around threads when room isn't yet in store ([\matrix-org#8496](matrix-org#8496)). Fixes element-hq/element-web#22047. * Fix reading of cached room device setting values ([\matrix-org#8491](matrix-org#8491)). * Add loading spinners to threads panels ([\matrix-org#8490](matrix-org#8490)). Fixes element-hq/element-web#21335. * Fix forwarding UI papercuts ([\matrix-org#8482](matrix-org#8482)). Fixes element-hq/element-web#17616.
su-ex
added a commit
to SchildiChat/element-web
that referenced
this pull request
May 28, 2022
* Go to space landing page when clicking on a selected space ([\element-hq#6442](matrix-org/matrix-react-sdk#6442)). Fixes element-hq#20296. * Fall back to untranslated string rather than showing missing translation error ([\element-hq#8609](matrix-org/matrix-react-sdk#8609)). * Show file name and size on images on hover ([\element-hq#6511](matrix-org/matrix-react-sdk#6511)). Fixes element-hq#18197. * Iterate on search results for message bubbles ([\element-hq#7047](matrix-org/matrix-react-sdk#7047)). Fixes element-hq#20315. * registration: redesign email verification page ([\element-hq#8554](matrix-org/matrix-react-sdk#8554)). Fixes element-hq#21984. * Show full thread message in hover title on thread summary ([\element-hq#8568](matrix-org/matrix-react-sdk#8568)). Fixes element-hq#22037. * Tweak video rooms copy ([\element-hq#8582](matrix-org/matrix-react-sdk#8582)). Fixes element-hq#22176. * Live location share - beacon tooltip in maximised view ([\element-hq#8572](matrix-org/matrix-react-sdk#8572)). * Add dialog to navigate long room topics ([\element-hq#8517](matrix-org/matrix-react-sdk#8517)). Fixes element-hq#9623. * Change spaceroomfacepile tooltip if memberlist is shown ([\element-hq#8571](matrix-org/matrix-react-sdk#8571)). Fixes element-hq#17406. * Improve message editing UI ([\element-hq#8483](matrix-org/matrix-react-sdk#8483)). Fixes element-hq#9752 and element-hq#22108. * Make date changes more obvious ([\element-hq#6410](matrix-org/matrix-react-sdk#6410)). Fixes element-hq#16221. * Enable forwarding static locations ([\element-hq#8553](matrix-org/matrix-react-sdk#8553)). * Log `TimelinePanel` debugging info when opening the bug report modal ([\element-hq#8502](matrix-org/matrix-react-sdk#8502)). * Improve welcome screen, add opt-out analytics ([\element-hq#8474](matrix-org/matrix-react-sdk#8474)). Fixes element-hq#21946. * Converting selected text to MD link when pasting a URL ([\element-hq#8242](matrix-org/matrix-react-sdk#8242)). Fixes element-hq#21634. Contributed by @Sinharitik589. * Support Inter on custom themes ([\element-hq#8399](matrix-org/matrix-react-sdk#8399)). Fixes element-hq#16293. * Add a `Copy link` button to the right-click message context-menu labs feature ([\element-hq#8527](matrix-org/matrix-react-sdk#8527)). * Move widget screenshots labs flag to devtools ([\element-hq#8522](matrix-org/matrix-react-sdk#8522)). * Remove some labs features which don't get used or create maintenance burden: custom status, multiple integration managers, and do not disturb ([\element-hq#8521](matrix-org/matrix-react-sdk#8521)). * Add a way to toggle `ScrollPanel` and `TimelinePanel` debug logs ([\element-hq#8513](matrix-org/matrix-react-sdk#8513)). * Spaces: remove blue beta dot ([\element-hq#8511](matrix-org/matrix-react-sdk#8511)). Fixes element-hq#22061. * Order new search dialog results by recency ([\element-hq#8444](matrix-org/matrix-react-sdk#8444)). * Improve pills ([\element-hq#6398](matrix-org/matrix-react-sdk#6398)). Fixes element-hq#16948 and element-hq#21281. * Add a way to maximize/pin widget from the PiP view ([\element-hq#7672](matrix-org/matrix-react-sdk#7672)). Fixes element-hq#20723. * Iterate video room designs in labs ([\element-hq#8499](matrix-org/matrix-react-sdk#8499)). * Improve UI/UX in calls ([\element-hq#7791](matrix-org/matrix-react-sdk#7791)). Fixes element-hq#19937. * Add ability to change audio and video devices during a call ([\element-hq#7173](matrix-org/matrix-react-sdk#7173)). Fixes element-hq#15595. * Fix video rooms sometimes connecting muted when they shouldn't ([\element-hq#22125](element-hq#22125)). * Avoid flashing the 'join conference' button at the user in video rooms ([\element-hq#22120](element-hq#22120)). * Fully close Jitsi conferences on errors ([\element-hq#22060](element-hq#22060)). * Fix click behavior of notification badges on spaces ([\element-hq#8627](matrix-org/matrix-react-sdk#8627)). Fixes element-hq#22241. * Add missing return values in Read Receipt animation code ([\element-hq#8625](matrix-org/matrix-react-sdk#8625)). Fixes element-hq#22175. * Fix 'continue' button not working after accepting identity server terms of service ([\element-hq#8619](matrix-org/matrix-react-sdk#8619)). Fixes element-hq#20003. * Proactively fix stuck devices in video rooms ([\element-hq#8587](matrix-org/matrix-react-sdk#8587)). Fixes element-hq#22131. * Fix position of the message action bar on left side bubbles ([\element-hq#8398](matrix-org/matrix-react-sdk#8398)). Fixes element-hq#21879. Contributed by @luixxiul. * Fix edge case thread summaries around events without a msgtype ([\element-hq#8576](matrix-org/matrix-react-sdk#8576)). * Fix favourites metaspace not updating ([\element-hq#8594](matrix-org/matrix-react-sdk#8594)). Fixes element-hq#22156. * Stop spaces from displaying as rooms in new breadcrumbs ([\element-hq#8595](matrix-org/matrix-react-sdk#8595)). Fixes element-hq#22165. * Fix avatar position of hidden event on ThreadView ([\element-hq#8592](matrix-org/matrix-react-sdk#8592)). Fixes element-hq#22199. Contributed by @luixxiul. * Fix MessageTimestamp position next to redacted messages on IRC/modern layout ([\element-hq#8591](matrix-org/matrix-react-sdk#8591)). Fixes element-hq#22181. Contributed by @luixxiul. * Fix padding of messages in threads ([\element-hq#8574](matrix-org/matrix-react-sdk#8574)). Contributed by @luixxiul. * Enable overflow of hidden events content ([\element-hq#8585](matrix-org/matrix-react-sdk#8585)). Fixes element-hq#22187. Contributed by @luixxiul. * Increase composer line height to avoid cutting off emoji ([\element-hq#8583](matrix-org/matrix-react-sdk#8583)). Fixes element-hq#22170. * Don't consider threads for breaking continuation until actually created ([\element-hq#8581](matrix-org/matrix-react-sdk#8581)). Fixes element-hq#22164. * Fix displaying hidden events on threads ([\element-hq#8555](matrix-org/matrix-react-sdk#8555)). Fixes element-hq#22058. Contributed by @luixxiul. * Fix button width and align 絵文字 (emoji) on the user panel ([\element-hq#8562](matrix-org/matrix-react-sdk#8562)). Fixes element-hq#22142. Contributed by @luixxiul. * Standardise the margin for settings tabs ([\element-hq#7963](matrix-org/matrix-react-sdk#7963)). Fixes element-hq#20767. Contributed by @yuktea. * Fix room history not being visible even if we have historical keys ([\element-hq#8563](matrix-org/matrix-react-sdk#8563)). Fixes element-hq#16983. * Fix oblong avatars in video room lobbies ([\element-hq#8565](matrix-org/matrix-react-sdk#8565)). * Update thread summary when latest event gets decrypted ([\element-hq#8564](matrix-org/matrix-react-sdk#8564)). Fixes element-hq#22151. * Fix codepath which can wrongly cause automatic space switch from all rooms ([\element-hq#8560](matrix-org/matrix-react-sdk#8560)). Fixes element-hq#21373. * Fix effect of URL preview toggle not updating live ([\element-hq#8561](matrix-org/matrix-react-sdk#8561)). Fixes element-hq#22148. * Fix visual bugs on AccessSecretStorageDialog ([\element-hq#8160](matrix-org/matrix-react-sdk#8160)). Fixes element-hq#19426. Contributed by @luixxiul. * Fix the width bounce of the clock on the AudioPlayer ([\element-hq#8320](matrix-org/matrix-react-sdk#8320)). Fixes element-hq#21788. Contributed by @luixxiul. * Hide the verification left stroke only on the thread list ([\element-hq#8525](matrix-org/matrix-react-sdk#8525)). Fixes element-hq#22132. Contributed by @luixxiul. * Hide recently_viewed dropdown when other modal opens ([\element-hq#8538](matrix-org/matrix-react-sdk#8538)). Contributed by @yaya-usman. * Only jump to date after pressing the 'go' button ([\element-hq#8548](matrix-org/matrix-react-sdk#8548)). Fixes element-hq#20799. * Fix download button not working on events that were decrypted too late ([\element-hq#8556](matrix-org/matrix-react-sdk#8556)). Fixes element-hq#19427. * Align thread summary button with bubble messages on the left side ([\element-hq#8388](matrix-org/matrix-react-sdk#8388)). Fixes element-hq#21873. Contributed by @luixxiul. * Fix unresponsive notification toggles ([\element-hq#8549](matrix-org/matrix-react-sdk#8549)). Fixes element-hq#22109. * Set color-scheme property in themes ([\element-hq#8547](matrix-org/matrix-react-sdk#8547)). Fixes element-hq#22124. * Improve the styling of error messages during search initialization. ([\element-hq#6899](matrix-org/matrix-react-sdk#6899)). Fixes element-hq#19245 and element-hq#18164. Contributed by @KalleStruik. * Don't leave button tooltips open when closing modals ([\element-hq#8546](matrix-org/matrix-react-sdk#8546)). Fixes element-hq#22121. * update matrix-analytics-events ([\element-hq#8543](matrix-org/matrix-react-sdk#8543)). * Handle Jitsi Meet crashes more gracefully ([\element-hq#8541](matrix-org/matrix-react-sdk#8541)). * Fix regression around pasting links ([\element-hq#8537](matrix-org/matrix-react-sdk#8537)). Fixes element-hq#22117. * Fixes suggested room not ellipsized on shrinking ([\element-hq#8536](matrix-org/matrix-react-sdk#8536)). Contributed by @yaya-usman. * Add global spacing between display name and location body ([\element-hq#8523](matrix-org/matrix-react-sdk#8523)). Fixes element-hq#22111. Contributed by @luixxiul. * Add box-shadow to the reply preview on the main (left) panel only ([\element-hq#8397](matrix-org/matrix-react-sdk#8397)). Fixes element-hq#21894. Contributed by @luixxiul. * Set line-height: 1 to RedactedBody inside GenericEventListSummary for IRC/modern layout ([\element-hq#8529](matrix-org/matrix-react-sdk#8529)). Fixes element-hq#22112. Contributed by @luixxiul. * Fix position of timestamp on the chat panel in IRC layout and message edits history modal window ([\element-hq#8464](matrix-org/matrix-react-sdk#8464)). Fixes element-hq#22011 and element-hq#22014. Contributed by @luixxiul. * Fix unexpected and inconsistent inheritance of line-height property for mx_TextualEvent ([\element-hq#8485](matrix-org/matrix-react-sdk#8485)). Fixes element-hq#22041. Contributed by @luixxiul. * Set the same margin to the right side of NewRoomIntro on TimelineCard ([\element-hq#8453](matrix-org/matrix-react-sdk#8453)). Contributed by @luixxiul. * Remove duplicate tooltip from user pills ([\element-hq#8512](matrix-org/matrix-react-sdk#8512)). * Set max-width for MLocationBody and MLocationBody_map by default ([\element-hq#8519](matrix-org/matrix-react-sdk#8519)). Fixes element-hq#21983. Contributed by @luixxiul. * Simplify ReplyPreview UI implementation ([\element-hq#8516](matrix-org/matrix-react-sdk#8516)). Fixes element-hq#22091. Contributed by @luixxiul. * Fix thread summary overflow on narrow message panel on bubble message layout ([\element-hq#8520](matrix-org/matrix-react-sdk#8520)). Fixes element-hq#22097. Contributed by @luixxiul. * Live location sharing - refresh beacon timers on tab becoming active ([\element-hq#8515](matrix-org/matrix-react-sdk#8515)). * Enlarge emoji again ([\element-hq#8509](matrix-org/matrix-react-sdk#8509)). Fixes element-hq#22086. * Order receipts with the most recent on the right ([\element-hq#8506](matrix-org/matrix-react-sdk#8506)). Fixes element-hq#22044. * Disconnect from video rooms when leaving ([\element-hq#8500](matrix-org/matrix-react-sdk#8500)). * Fix soft crash around threads when room isn't yet in store ([\element-hq#8496](matrix-org/matrix-react-sdk#8496)). Fixes element-hq#22047. * Fix reading of cached room device setting values ([\element-hq#8491](matrix-org/matrix-react-sdk#8491)). * Add loading spinners to threads panels ([\element-hq#8490](matrix-org/matrix-react-sdk#8490)). Fixes element-hq#21335. * Fix forwarding UI papercuts ([\element-hq#8482](matrix-org/matrix-react-sdk#8482)). Fixes element-hq#17616.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#22041
This PR fixes the unexpected inheritance of
line-height
property formx_TextualEvent
.$font-22px
is inherited from_GroupLayout.scss
$font-18px
is inherited from_EventBubbleTile.scss
Peek.2022-05-03.19-06.mp4
type: defect
Signed-off-by: Suguru Hirahara [email protected]
Here's what your changelog entry will look like:
🐛 Bug Fixes