Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Organize UserInfo.scss #8461

Merged
merged 19 commits into from
May 23, 2022
Merged

Organize UserInfo.scss #8461

merged 19 commits into from
May 23, 2022

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 2, 2022

This is a follow-up to #8247.

  • Organize style rules to prevent a visual bug
  • Replace a wildcard as it is costly
  • Use variables

Signed-off-by: Suguru Hirahara [email protected]

type: task


This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label May 2, 2022
@luixxiul luixxiul marked this pull request as ready for review May 2, 2022 07:44
@luixxiul luixxiul requested a review from a team as a code owner May 2, 2022 07:44
@luixxiul luixxiul marked this pull request as draft May 11, 2022 07:15
luixxiul added 6 commits May 11, 2022 17:27
.mx_UserInfo_avatar > div > div *

Signed-off-by: Suguru Hirahara <[email protected]>
.mx_UserInfo_avatar > div > div

Signed-off-by: Suguru Hirahara <[email protected]>
.mx_UserInfo_avatar > div

Signed-off-by: Suguru Hirahara <[email protected]>
- .mx_BaseAvatar_initial
- .mx_BaseAvatar

Signed-off-by: Suguru Hirahara <[email protected]>
@luixxiul luixxiul marked this pull request as ready for review May 11, 2022 08:42
luixxiul added 9 commits May 12, 2022 12:39
Move .mx_BaseAvatar_initial under .mx_BaseAvatar

Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
To prevent the icon from moving down a little bit

Signed-off-by: Suguru Hirahara <[email protected]>
Signed-off-by: Suguru Hirahara <[email protected]>
@t3chguy
Copy link
Member

t3chguy commented May 18, 2022

Could you please pull latest develop into this one, the Netlify action in it is broken so I can't get a working build out of it

@luixxiul
Copy link
Contributor Author

I see, I did it just now.

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me, thanks!

@t3chguy t3chguy merged commit 20fd68b into matrix-org:develop May 23, 2022
@luixxiul
Copy link
Contributor Author

@t3chguy Thank you for reviewing 😄

@luixxiul luixxiul deleted the UserInfo2 branch May 23, 2022 12:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants