Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Use redaction enum event type rather than hardcoded string #8071

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Mar 17, 2022

A few instances that I stumbled upon


This PR currently has no changelog labels, so will not be included in changelogs.

Add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is plus X-Breaking-Change if it's a breaking change.

Preview: https://pr8071--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.

@germain-gg germain-gg requested a review from a team as a code owner March 17, 2022 11:31
@germain-gg germain-gg enabled auto-merge (squash) March 17, 2022 11:31
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #8071 (24ff09c) into develop (176e49e) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##           develop    #8071   +/-   ##
========================================
  Coverage    27.12%   27.12%           
========================================
  Files          868      868           
  Lines        52097    52097           
  Branches     13199    13199           
========================================
  Hits         14130    14130           
  Misses       37967    37967           
Impacted Files Coverage Δ
...ponents/views/dialogs/MessageEditHistoryDialog.tsx 0.00% <0.00%> (ø)

Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@germain-gg germain-gg merged commit 4e4ce65 into develop Mar 17, 2022
@germain-gg germain-gg deleted the gsouquet/redaction-event-type branch March 17, 2022 17:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants