Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

set mask-size for icons #7812

Merged
merged 1 commit into from
Feb 16, 2022
Merged

set mask-size for icons #7812

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions res/css/views/context_menus/_IconizedContextMenu.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ limitations under the License.
width: 16px;
min-width: 16px;
max-width: 16px;
mask-size: contain;
Copy link
Member

@t3chguy t3chguy Feb 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icon itself shouldn't bear a mask, that's applied to the ::before element - the bug here is actually that the mask is being applied to the wrong element - See

matrix-react-sdk/res/css/views/rooms/_RoomList.scss

Lines 36 to 41 in 8fe582b

.mx_RoomList_iconStartChat {
mask-image: url('$(res)/img/element-icons/roomlist/member-plus.svg');
}
.mx_RoomList_iconInvite {
mask-image: url('$(res)/img/element-icons/room/share.svg');
}
and compare it to the mask-images above

}

span.mx_IconizedContextMenu_label { // labels
Expand Down