This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Attempt to fix the flakyness seen with tests #781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
actually meant that the room directory wasn't displayed - probably because the dispatch
view_room_directory
ended up on another tick of the event loop, meaning that the directory wasn't displayedi. The fix attempted in ths commit is to usethis._setPage
instead to view the directory. This usessetState
to set the screen to the directory, so I'm not entirely convinced this will solve the problem (assetState
may also end up doing things on another tick.and
was happening probably because in the handler for the
sync
event inMatrixChat
(around line 840), there was one case in which theready
state may not be true (causing all 5 attempts to fail), and this case relied onstarting_room_alias_payload
. Thisstarting_room_alias_payload
is now redundant because ofinitialScreenAfterLogin
, which was added recently.