This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 827
Convert /src/components/views/elements
to TS
#6815
Merged
turt2live
merged 20 commits into
matrix-org:develop
from
SimonBrandner:task/elements-ts
Sep 21, 2021
Merged
Convert /src/components/views/elements
to TS
#6815
turt2live
merged 20 commits into
matrix-org:develop
from
SimonBrandner:task/elements-ts
Sep 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
T-Task
Refactoring, enabling or disabling functionality, other engineering tasks
label
Sep 15, 2021
SimonBrandner
force-pushed
the
task/elements-ts
branch
7 times, most recently
from
September 17, 2021 16:10
6e762e6
to
1de2bd0
Compare
SimonBrandner
commented
Sep 17, 2021
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/elements-ts
branch
from
September 17, 2021 16:42
1de2bd0
to
8223137
Compare
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/elements-ts
branch
from
September 17, 2021 16:47
8223137
to
e1445f7
Compare
Closed
SimonBrandner
changed the title
Convert
Convert Sep 20, 2021
/elements
to TS/src/components/views/elements
to TS
turt2live
suggested changes
Sep 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good - thanks! We'll also land this after the RC.
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/elements-ts
branch
from
September 20, 2021 15:23
76e1ecb
to
ec4f672
Compare
Signed-off-by: Šimon Brandner <[email protected]>
SimonBrandner
force-pushed
the
task/elements-ts
branch
from
September 21, 2021 07:09
db1866c
to
24df63a
Compare
turt2live
approved these changes
Sep 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: task
Fixes element-hq/element-web#19061
Requires matrix-org/matrix-js-sdk#1927
This leaves out the group and tag components for obvious reasons. Also,
Pill.js
conversion is in #6398This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://6149861842a6f57b6f05ad24--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.