Use styled mxids in member list #6328
Conversation
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
|
Wouldn't it style better if the disambiguated username goes below the name displayed there? Else it'll be cut off if the displayname is too long. (For that matter, wouldn't it make sense to always show usernames under displaynames in the sidebar? I think it warrants to always display info like that in a sidebar) |
|
Keep in mind below is already used for status/presence
|
No, hiding MXIDs in as many places as is sane is very much intentional. |
|
Good point, though i still think it cutting off if the displayname is too long could be an annoyance. |
|
They already get cut off in the current version. At least the font size is a bit smaller here so it will require more characters to be cut off. If the user doesn't want it to cut off the usernames they can expand the right panel. |
…uated-profile/14825 Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
…uated-profile/14825
…uated-profile/14825 Signed-off-by: Šimon Brandner <[email protected]>
…uated-profile/14825
Signed-off-by: Šimon Brandner <[email protected]>
Signed-off-by: Šimon Brandner <[email protected]>
|
This has been blocked on review by design for 9 months (cc @nadonomy), and it's a concrete useful security feature (unspoofable disambiguation) which from the screenshots is a clear cosmetic improvement. So I'm making an exec decision to approve it. @SimonBrandner - thanks for doing it, and sorry it got stuck for so long. |
|
(have tried to fix the merge conflict from within GH issue UI 'blind', hopefully it worked... :S) |
|
Looks like it's failing modern code checks - will take a look shortly. |
|
ftr, this missed #7595 but have re-applied it. From looking at the merge diff, it's the only feature at risk. Should be safe to include this in the RC tomorrow. If not, it's an easy revert and something we can re-apply onto develop. |
This reverts commit 5d28e05.
|
this ended up getting reverted - see #8107 for details |
…atrix-org#8107)" This reverts commit 709e6e7.
* Revert "Revert "Use styled mxids in member list (#6328)" (#8107)" This reverts commit 709e6e7. * Fix disambiguated profile for bubbles Signed-off-by: Šimon Brandner <[email protected]>
Fixes element-hq/element-web#14825
Preview: https://pr6328--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.