This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
EventTilePreview fixes #6000
Merged
EventTilePreview fixes #6000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduces the blurriness of avatars in the EventTilePreview. Signed-off-by: Robin Townsend <[email protected]>
MemberAvatar requires a display name, or else it refuses to render. Signed-off-by: Robin Townsend <[email protected]>
|
Also, PR 6000 ;) |
turt2live
suggested changes
May 11, 2021
|
Reverted the thumbnail size change as I wasn't aware that 32 is just the value that's used everywhere. This should just be the one bug fix for when the user doesn't have a display name, then |
It was a bullet point, since EventTiles now get created as li by default :P Signed-off-by: Robin Townsend <[email protected]>
|
Also removed the mystery dot added by #6154
|
Because of 91df392, we now need to additionally set rawDisplayName to properly fake our display name for an event. Signed-off-by: Robin Townsend <[email protected]>
turt2live
approved these changes
Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple of things I noticed while referencing EventTilePreview code for #5999. (see commits)
Fixes element-hq/element-web#17621