This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add support for deleting threepids #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ara4n
reviewed
Dec 22, 2016
| return this._refreshFromServer(); | ||
| }).catch((e) => { | ||
| const ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | ||
| Modal.createDialog(ErrorDialog, { |
There was a problem hiding this comment.
will creating a modal from within an existing modal work? I vaguely remember having to put the second create into a setTimeout(0) to let the other one first disappear...?
There was a problem hiding this comment.
Empirically it seems to be fine (although I did get the variable name wrong)
ara4n
reviewed
Dec 22, 2016
| @@ -507,7 +531,7 @@ module.exports = React.createClass({ | |||
| this.state.avatarUrl ? MatrixClientPeg.get().mxcUrlToHttp(this.state.avatarUrl) : null | |||
| ); | |||
|
|
|||
| var threepidsSection = this.state.threepids.map(function(val, pidIndex) { | |||
| var threepidsSection = this.state.threepids.map((val, pidIndex) => { | |||
| var id = "email-" + val.address; | |||
|
lgtm mod comments |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires element-hq/element-web#2784
Requires matrix-org/matrix-js-sdk#312