Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Design for reactions which could not be sent #5954

Closed
wants to merge 5 commits into from

Conversation

DantrazTrev
Copy link
Contributor

@DantrazTrev DantrazTrev commented May 3, 2021

Fixes element-hq/element-web#9692

Added the EventStatus.NOT_SENT the one used in Resend Reactions to determine the reactions to resend to the ReactionRowsButton for the logic of Failed to sent responses

    const failed =Boolean(mxEvent.staus === EventStatus.NOT_SENT)

Added mx_ReactionsRowButton_failed class to render a failed event . Although it needs a bit more design (The image shows a failed to send reaction)

image

Signed-off-by : Ayush Pratap Singh [email protected]


Here's what your changelog entry will look like:

🐛 Bug Fixes

@DantrazTrev DantrazTrev marked this pull request as ready for review May 7, 2021 13:52
@turt2live turt2live requested review from a team May 27, 2021 18:43
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great to see that we will be able to determine which reactions have stalled

Let's probably wait for the design review, but I'd suggest to add extra information (maybe on hover?) as to why this reaction has turned red, and make it clear to a user how they can resend the reaction

Comment on lines 37 to 38
background-color: rgba(140, 12, 12, 0.748);
border-color: rgba(68, 0, 0, 0.748);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those two colours should probably be stored in a variable as we might want to use a slightly different shade for contrast depending on the theme used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

src/components/views/messages/ReactionsRowButton.js Outdated Show resolved Hide resolved
@DantrazTrev
Copy link
Contributor Author

It's great to see that we will be able to determine which reactions have stalled

Let's probably wait for the design review, but I'd suggest to add extra information (maybe on hover?) as to why this reaction has turned red, and make it clear to a user how they can resend the reaction

That would help a lot, As an alternative, I'm thinking of something like a red exclamation icon at the end of the failed reaction?

@MadLittleMods MadLittleMods added Z-Community-PR Issue is solved by a community member's PR T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jun 2, 2022
@richvdh richvdh changed the title Failed reactions Design Design for reactions which could not be sent Nov 10, 2022
@andybalaam
Copy link
Member

Hi, thank you for your work on this. We want the design team to take a look at it, and since the linked issue has the right tag on it, it will eventually get to the front of the queue.

Meanwhile, the actual code here is quite short and has bit-rotted, so I am going to close this PR, and hope that someone can create a new one (possibly based on this one) when design get back to us.

Thanks again, and I really hope we will get this feature soon(ish).

@andybalaam andybalaam closed this Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregations: Handle failures when sending
4 participants