-
-
Notifications
You must be signed in to change notification settings - Fork 828
Design for reactions which could not be sent #5954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's great to see that we will be able to determine which reactions have stalled
Let's probably wait for the design review, but I'd suggest to add extra information (maybe on hover?) as to why this reaction has turned red, and make it clear to a user how they can resend the reaction
background-color: rgba(140, 12, 12, 0.748); | ||
border-color: rgba(68, 0, 0, 0.748); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those two colours should probably be stored in a variable as we might want to use a slightly different shade for contrast depending on the theme used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Co-authored-by: Germain <[email protected]>
Signed-off-by: Ayush PS <[email protected]>
…rix-react-sdk into Reaction-Failsyt
That would help a lot, As an alternative, I'm thinking of something like a red exclamation icon at the end of the failed reaction? |
Hi, thank you for your work on this. We want the design team to take a look at it, and since the linked issue has the right tag on it, it will eventually get to the front of the queue. Meanwhile, the actual code here is quite short and has bit-rotted, so I am going to close this PR, and hope that someone can create a new one (possibly based on this one) when design get back to us. Thanks again, and I really hope we will get this feature soon(ish). |
Fixes element-hq/element-web#9692
Added the
EventStatus.NOT_SENT
the one used inResend Reactions
to determine the reactions to resend to theReactionRowsButton
for the logic of Failed to sent responsesAdded
mx_ReactionsRowButton_failed
class to render a failed event . Although it needs a bit more design (The image shows a failed to send reaction)Signed-off-by : Ayush Pratap Singh [email protected]
Here's what your changelog entry will look like:
🐛 Bug Fixes