Share keys for historical messages when inviting users to encrypted rooms

[uhoreg]

Depends on matrix-org/matrix-js-sdk#1640

[dbkr]

otherwise lgtm

[jryans]

I'm looking over the JS SDK changes today, but just wanted to highlight here that the Design review could potentially be skipped if we need to move faster, since this is disabled behind a feature flag.

[niquewoodhouse]

Hi @uhoreg

Some design feedback from me: It could be a bit alarming for non-technical users - the way its presented makes it feel like you should note this before inviting people (which might be by design), but the words themselves are potentially scary (decryption keys - what are they, what am I sharing with people) and could just stop some people from inviting anyone.

I've just got some suggested redesigns below. I don't have great context on what the problem you're solving is, and these are a bit rushed, so these might not feel right to you but I'm happy to discuss.

1

I think the text is just saying people will be able to read old messages - do we have to say decryption keys?

2

Same idea really - but without an info icon

And these ideas are if we have to say decryption keys - but I would personally say that could be alarming for people.

3

If we have to say decryption keys (I genuinely think its a scary thing to say, for people who don't know what it means, like me)

4

If we absolutely have to say decryption keys, softening it with a tooltip

5

Have a learn more link that just expands a bit of in-page content.

[uhoreg]

New design:

[niquewoodhouse]

Looks good, will test when shipped to suggest tweaks if required (eg does icon make sense in practice). Thnaks