Add a warning on E2EE rooms if you try to make them public

[SimonBrandner]

Fixes #16525

[jryans]

Looks like M's comment on the issue covers the Product side.

[Half-Shot]

Wondering if you'd also want to warn about turning encryption on in a public room, for much the same reason?

[SimonBrandner]

@Half-Shot, good point, thanks!

[turt2live]

I'm not entirely sold on the wording - it feels a bit too aggressive for a point where the user hasn't made a mistake yet. Will run it by the team internally.

[jryans]

Maybe a Design review can assist with copy editing here...?

[niquewoodhouse]

Finally gave this a go. Tried to make it a bit less technical and explain things out a bit more. Can someone who understands how things actually work check if this makes sense, please

Are you sure you want to make this encrypted room public?

It’s not recommended to make end-to-end encrypted rooms public. It means anyone can find and join this room, so anyone can read messages. You’ll get none of the benefits of encryption, and you can’t turn it off. Encrypting messages in a public room will also likely make receiving and sending messages slower than necessary.

To avoid these issues, create a new public room* for the conversation you plan to have.

*(New public room) could link to the create new room dialog, with public active?

[SimonBrandner]

@niquewoodhouse, that sounds great to me. Do you have any thoughts on the other dialog?

[SimonBrandner]

Actually, sorry:

and you can’t turn it off

Sounds like a thing for the other dialog

[SimonBrandner]

This is how the dialog loosk now

[niquewoodhouse]

@niquewoodhouse, that sounds great to me. Do you have any thoughts on the other dialog?

Are you sure you want to add encryption to this public room?

It’s not recommended to turn on encryption on for public rooms. Anyone can find and join public rooms, so anyone can read messages. You’ll get none of the benefits of encryption, and you won't be able to turn it off later. Encrypting messages in a public room will also likely make receiving and sending messages slower than necessary.

To avoid these issues, create a new private encrypted room* for the conversation you plan to have.

*(New private encrypted room) could link to the create new room dialog, with public active?

[SimonBrandner]

@niquewoodhouse, both dialogs are now updated:

Do they seem alright this way?

[niquewoodhouse]

Upon further review,

amended copy is a bit simpler:

Are you sure you want to make this encrypted room public?

It’s not recommended to make encrypted rooms public. It will mean anyone can find and join the room, so anyone can read messages. You’ll get none of the benefits of encryption. Encrypting messages in a public room will make receiving and sending messages slower.

To avoid these issues, create a new public room for the conversation you plan to have.

---

Are you sure you want to add encryption to this public room?

It’s not recommended to add encryption to public rooms. Anyone can find and join public rooms, so anyone can read messages in them. You’ll get none of the benefits of encryption, and you won’t be able to turn it off later. Encrypting messages in a public room will make receiving and sending messages slower.

To avoid these issues, create a new encrypted room for the conversation you plan to have.

[SimonBrandner]

I've updated the copy:

[niquewoodhouse]

Thanks!

[turt2live]

otherwise lgtm: major points are excess spaces and the wrong kind of quotes.