This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
use a proper HTML sanitizer to strip <mx-reply>, rather than a regexp #5006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorunome
reviewed
Jul 17, 2020
| // We also run a nl2br over the result to fix the fallback representation. We do this | ||
| // after converting the text to safe HTML to avoid user-provided BR's from being converted. | ||
| if (!html) html = escapeHtml(body).replace(/\n/g, '<br/>'); | ||
| if (html) { |
There was a problem hiding this comment.
Maybe also check that the format is present and set to org.matrix.custom.html? Else the reply fallback is potentially created off of the wrong attribute
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, always sanitize the HTML before constructing a reply.