This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Support deactivating your account with SSO #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
added
the
X-Release-Blocker
jryans
approved these changes
Apr 8, 2020
| _onPasswordFieldChange(ev) { | ||
| this.setState({ | ||
| password: ev.target.value, | ||
| MatrixClientPeg.get().deactivateAccount(null, false).then(r => { |
There was a problem hiding this comment.
Hum, calling something as serious as deactiveAccount in a constructor feels scary to me, but I guess any server implementing the spec would first 401 here.
I assume you have to do it to present the right text in the button for SSO.
nadonomy
approved these changes
Apr 8, 2020
|
Merging to add this into the RC today. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#12940
I don't know why Riot refuses to accept my translatable strings:
Password authentication has also been tested and still works.