This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Wmwragg/direct chat sublist #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t large enough to support them
…top header isn't allways stuck
…e following map can fire
…fferent scroll methods available on macOSX, i.e. System Preferences>General>Show Scroll Bars
|
Can one of the admins verify this patch? |
| @@ -24,5 +25,34 @@ module.exports = { | |||
| getDisplayAliasForRoom: function(room) { | |||
| return room.getCanonicalAlias() || room.getAliases()[0]; | |||
| }, | |||
|
|
|||
| isDirectMessageRoom: function(room, me, ConferenceHandler, hideConferenceChans) { | |||
There was a problem hiding this comment.
Heads up that this function will change shortly once we've finally finally defined how to track which rooms are DMs in terms of room or user configuration state. This is fine for now though.
There was a problem hiding this comment.
Yep, made it a separate function, as you mentioned this when I was doing it, so this should be easily swapped out for the new behaviour once it's implemented.
|
LGTM other than minor comments. |
|
@matrixbot okay to test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A companion branch vector-im/vector-web:wmwragg/direct-chat-sublist also needs to be merged.
Signed-off-by: William Wragg [email protected]