This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Support changing options for .m.rule.tombstone push rule #2798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that users can't change push rules they don't have. Similar to the behaviour in matrix-org/matrix-js-sdk#860
This was referenced Mar 15, 2019
dbkr
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of element-hq/element-web#8447
See also matrix-org/matrix-spec-proposals#1930
Intended to be reviewed with matrix-org/matrix-js-sdk#860
Ends up doing this to the event:
When the server doesn't support the push rule (missing matrix-org/synapse#4867), the option is not shown. However, the option is always shown when the server supports it:
