This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix Room Directory custom homeserver entry not showing properly #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
changed the title
jryans
approved these changes
Feb 27, 2019
Will do :) |
Signed-off-by: Michael Telatynski <[email protected]>
jryans
approved these changes
Mar 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea what the hell happened in this file but there were a LOT of conflicting identifiers,
selectedInstance vs selectedInstanceId
includeAll vs includeAllNetworks
the initial State made no sense
custom entry behaviour was mismatched
Fixes element-hq/element-web#7364
Signed-off-by: Michael Telatynski [email protected]