This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement the "general" tab of new room settings #2516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests exploding due to branch mismatch on the js-sdk now. |
bwindels
approved these changes
Jan 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8255
Part of element-hq/element-web#7606
Some pieces are not as polished as they could be - these have been punted to a later stage in the process: element-hq/element-web#8207. The most obvious parts being the local aliases and local groups sections not being direct modification and using the old style text boxes (it is complicated to change either of these, and is probably best suited for a dedicated PR).
Note: I've intentionally disabled the RoomSettings tests. The component is going away eventually, and element-hq/element-web#8207 has an entry for "write tests". Tests might not happen this week though, because time.
Screenshots and gifs included:
(note the part where I stall after clicking save on the aliases - this is about the point where I remembered that the UI isn't perfect and will be polished later on)