This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Implement the "Notifications" tab of new user settings #2494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/usettings/tab/notifications
branch
from
5501ae9 to
d569892
Compare
|
Redesign note: No way to set which email you want notifs on :( |
|
I'm actually going to pull this from the review queue until the prior PR lands just to keep things sane on the Git side of things. |
turt2live
force-pushed
the
travis/usettings/tab/notifications
branch
from
d569892 to
30e8153
Compare
Introduces a new component to reduce code duplication
turt2live
force-pushed
the
travis/usettings/tab/notifications
branch
from
30e8153 to
98eb95b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8201
Part of element-hq/element-web#7605
Built on #2492Relevant changes are travis/usettings/tab/labs...travis/usettings/tab/notificationsNote: The table of notification options is specifically left untouched/unstyled due to lack of design. This whole tab is a candidate for complete redesign.