This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Destroy non-persistent widgets when switching room #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwindels
reviewed
Aug 1, 2018
| @@ -75,8 +75,6 @@ class ActiveWidgetStore extends EventEmitter { | |||
| destroyPersistentWidget() { | |||
| const toDeleteId = this._persistentWidgetId; | |||
|
|
|||
| const PersistedElement = sdk.getComponent("elements.PersistedElement"); | |||
| PersistedElement.destroyElement('widget_' + toDeleteId); | |||
There was a problem hiding this comment.
How come this didn't work? Seemed like a better place to do it...
There was a problem hiding this comment.
'cos it was trying to destroy the one current persistent widget, but in the case of a jitsi widget which got mounted because you were in its room but never became persistent, it wouldn't destroy anything. The subtle difference is tearing down the current persistent widget vs tearing down the widget in the current view which has been mounted in a persisted element.
bwindels
approved these changes
Aug 1, 2018
|
@dbkr Some lint errors remaining |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#7114