This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
fix set password & email flow possible to get stuck and onBlur murdering your email #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks plausible. Assigning @lukebarnard1 to make sure the change to the dispatch is sensible here. |
Looks better than before, if anything 👍 |
|
huh I'm not sure why the |
Given the changes do not match the commit messages, it'd be best. |
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
t3chguy
force-pushed
the
t3chguy/nvl/fix_set_password-email_flow
branch
from
b18ed6e to
9109d5b
Compare
|
I redid the commits with basically the same content |
|
(github's diff was a little weird, tried to unstick it) |
lukebarnard1
suggested changes
Jun 21, 2018
| @@ -169,15 +175,15 @@ export default class ChatCreateOrReuseDialog extends React.Component { | |||
| </p> | |||
| { profile } | |||
| </div> | |||
| <DialogButtons primaryButton={_t('Start Chatting')} | |||
| onPrimaryButtonClick={this.props.onNewDMClick} focus="true" /> | |||
| <DialogButtons primaryButton={_t('Start Chatting')} onCancel={this.onCancel} | |||
There was a problem hiding this comment.
This is a functional change, not delint.
t3chguy
force-pushed
the
t3chguy/nvl/fix_set_password-email_flow
branch
from
4629292 to
f2e4e51
Compare
|
@lukebarnard1 fixed that for you |
lukebarnard1
approved these changes
Jun 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if you refresh your browser after the SetPassword dialog, whilst in the SetEmail dialog, your password will have been changed but the NagBar will still nag you to change your password and fail every time because the password it remembers is now wrong.
and onBlur of the EditableText murdering the email you have input
Fixes element-hq/element-web#6366