Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

allow using tab to navigate room list in a smarter way #1977

Merged
merged 3 commits into from
Jun 22, 2018
Merged

allow using tab to navigate room list in a smarter way #1977

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff33ef4
allow using tab to navigate room list smarter
t3chguy Jun 16, 2018
423b893
simplify handled logic by inverting it
t3chguy Jun 16, 2018
6301c04
Merge branch 'develop' into t3chguy/ctrl-k_tab
t3chguy Jun 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/structures/LeftPanel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,24 +82,26 @@ var LeftPanel = React.createClass({

_onKeyDown: function(ev) {
if (!this.focusedElement) return;
let handled = false;
let handled = true;

switch (ev.keyCode) {
case KeyCode.TAB:
this._onMoveFocus(ev.shiftKey);
break;
case KeyCode.UP:
this._onMoveFocus(true);
handled = true;
break;
case KeyCode.DOWN:
this._onMoveFocus(false);
handled = true;
break;
case KeyCode.ENTER:
this._onMoveFocus(false);
if (this.focusedElement) {
this.focusedElement.click();
}
handled = true;
break;
default:
handled = false;
}

if (handled) {
Expand Down