This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 830
Message Pinning: rework the message pinning list in the right panel #12825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
added
the
T-Enhancement
New features, changes in functionality, performance boosts, user-facing improvements
label
Jul 25, 2024
florianduros
commented
Jul 27, 2024
florianduros
force-pushed
the
florianduros/pinned-messages/list
branch
from
August 7, 2024 16:35
6b7a05b
to
cfaddb0
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/list
branch
from
August 8, 2024 08:09
cfaddb0
to
d83b1d7
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/list
branch
from
August 9, 2024 09:49
d83b1d7
to
edae180
Compare
t3chguy
reviewed
Aug 14, 2024
florianduros
force-pushed
the
florianduros/pinned-messages/list
branch
from
August 14, 2024 15:45
68b52ed
to
02cea96
Compare
florianduros
force-pushed
the
florianduros/pinned-messages/list
branch
from
August 14, 2024 15:53
02cea96
to
c0c47c4
Compare
In future please avoid force pushing after a review was made as now I can't just review the diff since my last review |
@t3chguy Raaah I used git absorb to make the history cleaner, will do it after the review |
t3chguy
approved these changes
Aug 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
T-Enhancement
New features, changes in functionality, performance boosts, user-facing improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public
/exported
symbols have accurate TSDoc documentation.Figma: https://www.figma.com/design/nwbnk8RaZctjrrRGTUcx1X/Pinned-Messages?node-id=38-163717&t=QpPa8ByPpyclY6Wq-0
Part of https://github.com/element-hq/element-internal/issues/600 & https://github.com/element-hq/element-internal/issues/608
The PR can be reviewed commit by commit.
The content is the rework of the message pinning list in the right panel:
PinnedEventTile
to match figma design and behaviorPinnedMessagesCard
PinnedMessages