Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add a github action to check the base branch #12665

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Jun 20, 2024

It should be very rare that we ever PR into a branch that isn't 'develop', 'staging' or a feature branch, and this will give us a failed check when stacking up PRs on top of one another until the one below it is merged.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

It should be very rare that we ever PR into a branch that isn't
'develop', 'staging' or a feature branch, and this will give us a
failed check when stacking up PRs on top of one another until the
one below it is merged.
@dbkr dbkr added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 20, 2024
@dbkr dbkr marked this pull request as ready for review June 20, 2024 14:07
@dbkr dbkr requested a review from a team as a code owner June 20, 2024 14:07
@dbkr dbkr requested a review from t3chguy June 20, 2024 14:07
@dbkr dbkr added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@dbkr dbkr added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@dbkr dbkr added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit 0317755 Jun 20, 2024
31 checks passed
@dbkr dbkr deleted the dbkr/check_pr_base_branch branch June 20, 2024 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants