Replace SecurityCustomisations with CryptoSetupExtension

[thoraj]

Description

This PR is for the changes required for the CryptoSetupExtension. The extension is described in this issue, and also in the corresponding PR in matrix-react-sdk-module-api. The module-api PR has been merged, and the changes were released in v2.4.0.

SecurityCustomisations

We have asked about the deprecation of the SecurityCustomisations here in GH, and in the Element Web Development room (#element-dev:matrix.org). A decision must be made if CryptoSetupExtension will replace SecurityCustomisations immediately, or if there need to be a period of overlap where both are supported? As of 15.03.2024 we have not received any response/information about the matter.

Important this PR will remove the calls to the obsolete SecurityCustomisations, and replace them with the corresponding calls to CryptoSetupExtension (via ModuleRunner). (I have left the old calls as comments)

The rationale is that until Verji asked about the SecurityCustomisations the Element team had no plans to port them since no-one had notified the Element team that they were using them. Furthermore, AFAIK the customisation mechanism as such is deprecated and will be removed in the future.

Dependencies

This PR depends on matrix-react-sdk-module-api v2.4.0+, hence the checks will fail until matrix-react-sdk bumps the dependency from 2.3.0 => 2.4.0

Checklist

• Tests written for new code (and old code if feasible).
• New or updated public/exported symbols have accurate TSDoc documentation.
• Linter and other CI checks pass.
• Sign-off given on the changes (see CONTRIBUTING.md).

Signed-off-by: Thor Arne Johansen [email protected]

[richvdh]

I'm sorry this has taken so long for a decision.

A decision must be made if CryptoSetupExtension will replace SecurityCustomisations immediately, or if there need to be a period of overlap where both are supported?

I discussed this with the team last week; the answer was: we're not aware of anyone other than yourselves that are using SecurityCustomisations. If someone does come out of the woodwork, at least we're providing a replacement. As far as we are concerned, therefore, there is no need to maintain SecurityCustomisations.

[richvdh]

Thanks for this! A few comments.

[richvdh]

This is looking really good now, thank you for your perseverance! Just one small suggestion.

[thoraj]

@richvdh Thanks a lot for the very thorough review. I have implemented your last suggestions.

[richvdh]

Thank you so much for your perseverance!