Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

improve invite tile color #11721

Closed
wants to merge 2 commits into from
Closed

improve invite tile color #11721

wants to merge 2 commits into from

Conversation

gabrc52
Copy link
Contributor

@gabrc52 gabrc52 commented Oct 8, 2023

Signed-off-by: Gabriel Rodríguez [email protected]

Fixes #26098

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Notes: Fixes invite dialog pill color contrast

Before screenshots

See #26098

After screenshots

Dark theme (5.3 contrast ratio):

image

Light theme (3.5 contrast ratio):

image

Let us know if we should make a new variable (and how to name it!) or use an existing variable, or if you disagree with the color choice. There was no existing more specific alias for --cpd-color-blue-800: the closest was

--cpd-color-icon-info-primary: var(--cpd-color-blue-900);

but it does not seem to be enough contrast for dark theme.


This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@gabrc52 gabrc52 requested a review from a team as a code owner October 8, 2023 04:58
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Oct 8, 2023
@github-actions
Copy link

github-actions bot commented Oct 8, 2023

Thanks for opening this pull request, unfortunately we do not accept contributions from the main branch of your fork, please re-open once you switch to an alternative branch for everyone's sanity. See https://github.com/matrix-org/matrix-js-sdk/blob/develop/CONTRIBUTING.md

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invite dialog pills have poor styling
1 participant