Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

SecureBackupPanel: stop using deprecated APIs, and other fixes #11644

Merged
merged 5 commits into from
Sep 22, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Sep 21, 2023

Part of vector-im/crypto-internal#155

The first few commits are simple replacements of old APIs with new ones. The last couple are some correctness improvements while we're working on this.


This change is marked as an internal change (Task), so will not be included in the changelog.

@richvdh richvdh added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Sep 21, 2023
`MatrixClient.isKeyBackupTrusted` -> `CryptoApi.isKeyBackupTrusted`
`MatrixClient.getKeyBackupEnabled` -> `CryptoApi.getActiveSessionBackupVersion`
`MatrixClient.deleteKeyBackupVersion` -> `CryptoApi.deleteKeyBackupVersion`
We shouldn't say "zero sessions to back up" if we don't know.
@richvdh richvdh force-pushed the rav/securebackup_panel/update_api branch from c4459e8 to 3f60c66 Compare September 21, 2023 16:12
@richvdh richvdh marked this pull request as ready for review September 21, 2023 16:12
@richvdh richvdh requested a review from a team as a code owner September 21, 2023 16:12
@richvdh richvdh requested review from andybalaam and dbkr September 21, 2023 16:12
Copy link
Member

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question.

@richvdh richvdh added this pull request to the merge queue Sep 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 22, 2023
@richvdh richvdh added this pull request to the merge queue Sep 22, 2023
Merged via the queue into develop with commit 11f258e Sep 22, 2023
19 checks passed
@richvdh richvdh deleted the rav/securebackup_panel/update_api branch September 22, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants