This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use cypress-terminal-report #11226
Merged
Use cypress-terminal-report #11226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cypress plugin gives nice console logs about what is happening: I hope it will help us debug mysteriously failing tests. In its default config, it only logs for failing tests.
richvdh
added
the
T-Task
richvdh
commented
Jul 11, 2023
Comment on lines
+42
to
+44
| // disable logging of HTTP requests made to the Cypress server. They are noisy and not very helpful. | ||
| // @ts-ignore https://github.com/cypress-io/cypress/issues/26284 | ||
| morgan: false, |
There was a problem hiding this comment.
this disables the HTTP 7/10/2023 9:21:09 PM 127.0.0.1 GET /sw.js spam that cypress normally writes
t3chguy
previously requested changes
Jul 11, 2023
No it doesn't. I thought it did but that's because I can't read. |
|
We probably don't need to bridge |
|
To expand a bit more on the warning about console.log in the project's readme: if you look at the issue that resulted in the warning, the complaint is "I'm using
That situation is quite different to the use of |
|
It seems to make axe failures much harder to read Before After seems like this is due to the buffering causing the log order to be confusing. Axe failures end up in the middle of the log instead of at the bottom |
It's at the top (other than a couple of lines from the synapse startup/shutdown), no? |
Yes but only if its the first test overall, it'd get buried amongst output from our ~200 tests. But not a blocker either way |
richvdh
commented
Jul 11, 2023
| @@ -174,7 +174,7 @@ jobs: | |||
| record: true | |||
| parallel: true | |||
| command-prefix: "yarn percy exec --parallel --" | |||
| config: '{"reporter":"cypress-multi-reporters", "reporterOptions": { "configFile": "cypress-ci-reporter-config.json" } }' | |||
| config: '{"reporter":"cypress-multi-reporters", "reporterOptions": { "configFile": "cypress-ci-reporter-config.json" }, "morgan": false }' | |||
There was a problem hiding this comment.
I don't know why the config in cypress.config.ts isn't working here, and I don't know if this is going to fix it.
There was a problem hiding this comment.
Narrator: it did not fix it. The test logs include:
[percy] Running "cypress run --headed --record --parallel --config {"reporter":"cypress-multi-reporters", "reporterOptions": { "configFile": "cypress-ci-reporter-config.json" }, "morgan": false } --ci-build-id sha-c5befa1ef8ed72f0d09ae4fb5df21b4536b324f7-time-1689141941"
The following configuration option is invalid:
- morgan
well the other tests should be pretty silent. |
t3chguy
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cypress plugin gives nice console logs about what is happening: I hope it will help us debug mysteriously failing tests.
In its default config, it only logs for failing tests.
This change is marked as an internal change (Task), so will not be included in the changelog.