Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Remove default margin and padding from mx_TabbedView_tabLabels #10907

Merged
merged 1 commit into from
May 15, 2023
Merged

Remove default margin and padding from mx_TabbedView_tabLabels #10907

merged 1 commit into from
May 15, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 15, 2023

Fixes element-hq/element-web#25373

This PR intends to remove default margin and padding from ul with the class name mx_TabbedView_tabLabels.

0

type: task

Signed-off-by: Suguru Hirahara [email protected]

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels May 15, 2023
@luixxiul luixxiul marked this pull request as ready for review May 15, 2023 16:20
@luixxiul luixxiul requested a review from a team as a code owner May 15, 2023 16:20
@luixxiul luixxiul requested review from germain-gg and justjanne May 15, 2023 16:20
@luixxiul
Copy link
Contributor Author

With another PR I will create a Cypress + Percy test of the user settings tab 😉

@t3chguy t3chguy enabled auto-merge May 15, 2023 16:23
@t3chguy t3chguy added this pull request to the merge queue May 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2023
@t3chguy t3chguy merged commit 77d18f1 into matrix-org:develop May 15, 2023
@luixxiul luixxiul deleted the TabbedView branch May 15, 2023 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings modals have an unusually large margin
2 participants