Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Unit test list ordering algorithms #10682

Merged
merged 6 commits into from
Apr 25, 2023
Merged

Unit test list ordering algorithms #10682

merged 6 commits into from
Apr 25, 2023

Conversation

kerryarchibald
Copy link
Contributor

@kerryarchibald kerryarchibald commented Apr 21, 2023 •
edited by github-actions bot
Loading

Unit test ImportanceAlgorithm and NaturalAlgorithm before changing them in element-hq/element-web#25131

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@kerryarchibald kerryarchibald added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Apr 21, 2023
@kerryarchibald kerryarchibald marked this pull request as ready for review April 21, 2023 02:38
@kerryarchibald kerryarchibald requested a review from a team as a code owner April 21, 2023 02:38
@kerryarchibald kerryarchibald changed the title unit test ImportanceAlgorithm Unit test list ordering algorithms Apr 21, 2023
dbkr
dbkr approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks. These were desperately in need of tests (as you skips have demonstrated!)

@weeman1337 weeman1337 mentioned this pull request Apr 21, 2023
Merged
3 tasks
@kerryarchibald kerryarchibald added this pull request to the merge queue Apr 25, 2023
Merged via the queue into develop with commit 6c36a24 Apr 25, 2023
@kerryarchibald kerryarchibald deleted the kerry/test-importance-algorithm branch April 25, 2023 21:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@weeman1337 weeman1337 Awaiting requested review from weeman1337 weeman1337 is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerryarchibald @dbkr