Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Prefer React forwardRef in functional components over *Ref #10345

Closed
wants to merge 8 commits into from
Closed

Prefer React forwardRef in functional components over *Ref #10345

wants to merge 8 commits into from

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 9, 2023 •
edited by github-actions bot
Loading

For element-hq/element-web#14672

This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Mar 9, 2023
@t3chguy t3chguy marked this pull request as ready for review March 10, 2023 09:40
@t3chguy t3chguy requested a review from a team as a code owner March 10, 2023 09:40
kerryarchibald
kerryarchibald reviewed Mar 26, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's not required, but since typing refs is such a faff I think the new type errors should be fixed as part of this change.

@t3chguy t3chguy closed this Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kerryarchibald kerryarchibald kerryarchibald left review comments

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @kerryarchibald