Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Improve localization experience on Weblate #10140

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Improve localization experience on Weblate #10140

merged 3 commits into from
Feb 13, 2023

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 11, 2023

Signed-off-by: Suguru Hirahara [email protected]

This PR introduces changes which improve localization experience for translators on Weblate by using variables where they should be.

type: task

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This change is marked as an internal change (Task), so will not be included in the changelog.

@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Feb 11, 2023
@@ -3322,7 +3322,8 @@
"By approving access for this device, it will have full access to your account.": "By approving access for this device, it will have full access to your account.",
"Scan the QR code below with your device that's signed out.": "Scan the QR code below with your device that's signed out.",
"Start at the sign in screen": "Start at the sign in screen",
"Select 'Scan QR code'": "Select 'Scan QR code'",
"Select '%(scanQRCode)s'": "Select '%(scanQRCode)s'",
"Scan QR code": "Scan QR code",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used on Android and iOS projects. Check Weblate how automatic suggestion works, if you are not familiar with it.

@luixxiul luixxiul marked this pull request as ready for review February 11, 2023 08:54
@luixxiul luixxiul requested a review from a team as a code owner February 11, 2023 08:54
Copy link
Contributor

@florianduros florianduros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM, thanks.

@florianduros florianduros merged commit fa036a5 into matrix-org:develop Feb 13, 2023
@luixxiul luixxiul deleted the localization-2 branch February 13, 2023 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants