Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Commit

Permalink
Fix sliding sync test
Browse files Browse the repository at this point in the history
  • Loading branch information
@germain-gg
germain-gg committed Oct 21, 2022
1 parent a396acd commit 6922dad
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cypress/e2e/sliding-sync/sliding-sync.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ describe("Sliding Sync", () => {
cy.contains(".mx_RoomTile", "Test Room").should("not.have.class", "mx_NotificationBadge_count");
});

it("should not show unread indicators", () => { // TODO: for now. Later we should.
it.only("should not show unread indicators", () => { // TODO: for now. Later we should.

This comment has been minimized.

Sign in to view

Copy link
@t3chguy

t3chguy Oct 21, 2022

Member

this probably didn't want to get committed
createAndJoinBob();

// disable notifs in this room (TODO: CS API call?)
Expand All @@ -235,7 +235,7 @@ describe("Sliding Sync", () => {
"Test Room", "Dummy",
]);

cy.contains(".mx_RoomTile", "Test Room").get(".mx_NotificationBadge").should("not.exist");
cy.contains(".mx_RoomTile", "Test Room").get(".mx_NotificationBadge").should("not.be.visible");

This comment has been minimized.

Sign in to view

Copy link
@t3chguy

t3chguy Oct 21, 2022

Member

It seems strange we went from not exist to not visible, sounds like potential for DOM bloat?
});

it("should update user settings promptly", () => {
Expand Down

0 comments on commit 6922dad

Please sign in to comment.