a11y: add missing aria-label to delete button

matrix-org · Jun 20, 2024 · 587717f · 587717f
1 parent f74d97b
commit 587717f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src/components/views/settings/ThemeChoicePanel.tsx b/src/components/views/settings/ThemeChoicePanel.tsx
@@ -323,6 +323,7 @@ function CustomThemeList(): JSX.Element {
                     <li key={theme.name} className="mx_ThemeChoicePanel_CustomThemeList_theme" aria-label={theme.name}>
                         <span className="mx_ThemeChoicePanel_CustomThemeList_name">{theme.name}</span>
                         <IconButton
+                            aria-label={_t("action|delete")}
                             onClick={async () => {
                                 // Get the custom themes and do a cheap clone
                                 // To avoid to mutate the original array in the settings

diff --git a/test/components/views/settings/__snapshots__/ThemeChoicePanel-test.tsx.snap b/test/components/views/settings/__snapshots__/ThemeChoicePanel-test.tsx.snap
@@ -274,6 +274,7 @@ exports[`<ThemeChoicePanel /> custom theme should display custom theme 1`] = `
               Alice theme
             </span>
             <button
+              aria-label="Delete"
               class="_icon-button_16nk7_17"
               role="button"
               style="--cpd-icon-button-size: 32px;"
@@ -576,6 +577,7 @@ exports[`<ThemeChoicePanel /> custom theme should render the custom theme sectio
               Alice theme
             </span>
             <button
+              aria-label="Delete"
               class="_icon-button_16nk7_17"
               role="button"
               style="--cpd-icon-button-size: 32px;"