add hooks for m.call.* #201
Conversation
| @@ -621,6 +691,41 @@ def get_text_body(self, text, msgtype="m.text"): | |||
| "body": text | |||
| } | |||
|
|
|||
| def get_call_invite_content(self, call_id, sdp, version, lifetime, types="offer"): | |||
There was a problem hiding this comment.
Why is this dictionary constructed under a separate method rather than just in the method body of send_call_invite?
Stylistically, if kept as a separate method, types kwarg should probably be type.
| @@ -254,6 +254,76 @@ def send_message_event(self, room_id, event_type, content, txn_id=None, | |||
| params["ts"] = timestamp | |||
| return self._send("PUT", path, content, query_params=params) | |||
|
|
|||
| def send_call_invite(self, room_id, call_id, sdp, version, lifetime, | |||
| msgtype="m.call.invite", timestamp=None): | |||
| """Perform PUT /rooms/$room_id/send/m.room.call.invite | |||
There was a problem hiding this comment.
Looks like this is actually m.call.invite? https://matrix.org/speculator/spec/HEAD/client_server/unstable.html#module-voip
Yep, you've got it right in actual method; just need to fixup docstring.
| @@ -254,6 +254,76 @@ def send_message_event(self, room_id, event_type, content, txn_id=None, | |||
| params["ts"] = timestamp | |||
| return self._send("PUT", path, content, query_params=params) | |||
|
|
|||
| def send_call_invite(self, room_id, call_id, sdp, version, lifetime, | |||
| msgtype="m.call.invite", timestamp=None): | |||
There was a problem hiding this comment.
msgtype kwarg is never used. Probably just shouldn't be included in method signature at all.
| Args: | ||
| room_id (str): The room ID to send the event in. | ||
| call_id (str): Call identifier string. | ||
| sdp (dict): Session Description Protocol dict. |
There was a problem hiding this comment.
From spec, looks like sdp is a string rather than a dict?
| @@ -254,6 +254,76 @@ def send_message_event(self, room_id, event_type, content, txn_id=None, | |||
| params["ts"] = timestamp | |||
| return self._send("PUT", path, content, query_params=params) | |||
|
|
|||
| def send_call_invite(self, room_id, call_id, sdp, version, lifetime, | |||
There was a problem hiding this comment.
version should probably be kwarg with default value of 0.
| timestamp=timestamp | ||
| ) | ||
|
|
||
| def send_call_answer(self, room_id, call_id, sdp, version, lifetime, |
There was a problem hiding this comment.
Many comments from above appear to apply to all api methods.
| @@ -222,6 +222,50 @@ def send_audio(self, url, name, **audioinfo): | |||
| return self.client.api.send_content(self.room_id, url, name, "m.audio", | |||
| extra_information=audioinfo) | |||
|
|
|||
| def send_call_invite(self, call_id, sdp, version, lifetime): | |||
There was a problem hiding this comment.
These don't offer any additional abstraction over methods defined in api class. Until we have a reason to put methods here that make interacting with the api methods easier, probably just delete these methods.
Signed-off-by: Mathijs van Gorcum [email protected]