Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always return from _send even if it's irrelevant #167

Merged
merged 1 commit into from
Jan 3, 2018
Merged

always return from _send even if it's irrelevant #167

merged 1 commit into from
Jan 3, 2018

Conversation

Cadair
Copy link
Contributor

@Cadair Cadair commented Jan 3, 2018 •
edited
Loading

I have a asyncio subclass of the API that relies of getting the return value of _send so this always returns from send.

signed off by Stuart Mumford [email protected]

@Cadair
Copy link
Contributor Author

Cadair commented Jan 3, 2018

ci fail looks unrelated.

@non-Jedi
Copy link
Collaborator

non-Jedi commented Jan 3, 2018

Thanks! LGTM

@non-Jedi non-Jedi merged commit 83ff9b0 into matrix-org:master Jan 3, 2018
@Cadair Cadair deleted the return_send branch January 3, 2018 18:39
@Cadair Cadair mentioned this pull request Mar 21, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cadair @non-Jedi