Don't handle key verification requests which are immediately cancelled #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#10083 Fixes element-hq/element-web#9197 Fixes element-hq/element-web#8629 The issue is partially fixed by matrix-org/matrix-react-sdk#3123 in that users would no longer see "Incoming request", but would launch their client to a bunch of "key verification cancelled" dialogs. To work around this, we just don't handle key verification requests which we know are cancelled. The changes are a bit awkward (flagging the event as cancelled instead of filtering it) because: * We probably don't want to prevent events getting sent over the EventEmitter because applications may still rely on them. * The cypto side only has visibility of 1 event at a time, so it needs to have some kind of flag to rely on. An attempt has been made to generalize the new event flag for possible future cases.
dbkr
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
Slightly annoying that the sync code has to have special handling for verification requests: feels like we the layer above should be emitting events to the client once the whole sync is processed, having de-duped them etc, but that's a general problem with the js-sdk arch.
Yes, I 100% agree. v2 when? 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10083
Fixes element-hq/element-web#9197
Fixes element-hq/element-web#8629
The issue is partially fixed by matrix-org/matrix-react-sdk#3123 in that users would no longer see "Incoming request", but would launch their client to a bunch of "key verification cancelled" dialogs. To work around this, we just don't handle key verification requests which we know are cancelled.
The changes are a bit awkward (flagging the event as cancelled instead of filtering it) because:
An attempt has been made to generalize the new event flag for possible future cases.