Remove m.new_device support #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now rely on the server to track new devices, and tell us about them when users add them, rather than forcing devices to announce themselves (see element-hq/element-web#2305 for the whole backstory there). The necessary support for that has now been in all the clients and the server for several months (since March or so). I now want to get rid of the localstorage store, which this code is relying on, so now seems like a good time to get rid of it. Yay.
dbkr
approved these changes
Jul 6, 2017
manuroe
added a commit
to matrix-org/matrix-ios-sdk
that referenced
this pull request
Nov 21, 2017
ylecollen
pushed a commit
to matrix-org/matrix-android-sdk
that referenced
this pull request
Nov 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now rely on the server to track new devices, and tell us about them when
users add them, rather than forcing devices to announce themselves (see
element-hq/element-web#2305 for the whole backstory
there).
The necessary support for that has now been in all the clients and the server
for several months (since March or so). I now want to get rid of the
localstorage store, which this code is relying on, so now seems like a good
time to get rid of it. Yay.