Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DelayedEventInfo type #4446

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Fix DelayedEventInfo type #4446

merged 3 commits into from
Oct 15, 2024

Conversation

AndrewFerr
Copy link
Member

@AndrewFerr AndrewFerr commented Oct 10, 2024

for MSC4140's GET /delayed_events (as of 28970ec)

Note that this does not match the response type of the MSC's new /delayed_events/scheduled and delayed_events/finalized endpoints; this only fixes a typing error in the original response type.

Signed-off-by: Andrew Ferrazzutti [email protected]

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr AndrewFerr enabled auto-merge October 10, 2024 19:31
@AndrewFerr AndrewFerr added this pull request to the merge queue Oct 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2024
@AndrewFerr AndrewFerr added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@AndrewFerr AndrewFerr force-pushed the af/msc4140_fix-get-type branch from af0acea to 2792e77 Compare October 15, 2024 21:01
@AndrewFerr AndrewFerr added this pull request to the merge queue Oct 15, 2024
Merged via the queue into develop with commit 5f599ee Oct 15, 2024
26 checks passed
@AndrewFerr AndrewFerr deleted the af/msc4140_fix-get-type branch October 15, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants