Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate the crypto events which are not used by the rust-crypto #4442

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Deprecate the crypto events which are not used by the rust-crypto #4442

merged 2 commits into from
Oct 7, 2024

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Oct 4, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

Task element-hq/element-web#26922
Deprecate the crypto events which are no longer used by the rust crypto.

@florianduros florianduros mentioned this pull request Oct 4, 2024
Open
@florianduros florianduros added the T-Deprecation A pull request that makes something deprecated label Oct 4, 2024
@florianduros florianduros marked this pull request as ready for review October 4, 2024 13:58
@florianduros florianduros requested a review from a team as a code owner October 4, 2024 13:58
richvdh
richvdh approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

src/crypto/index.ts Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Oct 7, 2024
@florianduros florianduros removed this pull request from the merge queue due to a manual request Oct 7, 2024
@florianduros florianduros force-pushed the florianduros/rip-out-legacy-crypto/deprecate-crypto-event branch from 6073124 to 6d8ae87 Compare October 7, 2024 12:15
@florianduros florianduros enabled auto-merge October 7, 2024 12:15
@florianduros florianduros added this pull request to the merge queue Oct 7, 2024
Merged via the queue into develop with commit 0c9d82e Oct 7, 2024
26 checks passed
@florianduros florianduros deleted the florianduros/rip-out-legacy-crypto/deprecate-crypto-event branch October 7, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

@BillCarsonFr BillCarsonFr Awaiting requested review from BillCarsonFr BillCarsonFr is a code owner automatically assigned from matrix-org/element-crypto-web-reviewers

Assignees
No one assigned
Labels
T-Deprecation A pull request that makes something deprecated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@florianduros @richvdh