Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotate Matrix RTC media encryption key when a new member joins a call for Post Compromise Security #4422

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Rotate Matrix RTC media encryption key when a new member joins a call for Post Compromise Security #4422

merged 1 commit into from
Sep 27, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Sep 21, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns hughns changed the title Rotate RTC key when a new member joins a call Rotate RTC key when a new member joins a call for Post Compromise Security Sep 21, 2024
@hughns hughns changed the title Rotate RTC key when a new member joins a call for Post Compromise Security Rotate Matrix RTC media encryption key when a new member joins a call for Post Compromise Security Sep 21, 2024
@hughns hughns marked this pull request as ready for review September 21, 2024 15:18
@hughns hughns requested a review from a team as a code owner September 21, 2024 15:18
@hughns hughns added this pull request to the merge queue Sep 27, 2024
Merged via the queue into develop with commit 2d6230f Sep 27, 2024
46 of 47 checks passed
@hughns hughns deleted the hughns/rtc-rotate-key-on-joiner branch September 27, 2024 16:10
hughns added a commit that referenced this pull request Oct 25, 2024
@hughns
Do not rotate MatrixRTC media encryption key when a new member joins …
e69d91b 
…a call

This change reverts #4422.

Instead, the rotation when a new member joins will be reintroduced as part of supporting to-device based MatrixRTC encryption key distribution.
@hughns hughns mentioned this pull request Oct 25, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2024
@hughns
Do not rotate MatrixRTC media encryption key when a new member joins …
0a29063 
…a session (#4472)

* Do not rotate MatrixRTC media encryption key when a new member joins a call

This change reverts #4422.

Instead, the rotation when a new member joins will be reintroduced as part of supporting to-device based MatrixRTC encryption key distribution.

* Improve function name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hughns @AndrewFerr