Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry event decryption failures on first failure #4346

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Retry event decryption failures on first failure #4346

merged 2 commits into from
Aug 19, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Aug 12, 2024 •
edited
Loading

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns hughns force-pushed the hughns/rtc-decryption-retry branch from 305b341 to 7c53fe0 Compare August 12, 2024 15:58
@hughns
Copy link
Member Author

hughns commented Aug 12, 2024

This is a basic fix for element-hq/element-call#2560

@hughns hughns marked this pull request as ready for review August 12, 2024 16:38
@hughns hughns requested a review from a team as a code owner August 12, 2024 16:38
@hughns hughns mentioned this pull request Aug 12, 2024
Closed
@hughns hughns requested a review from AndrewFerr August 14, 2024 14:29
fkwp
fkwp approved these changes Aug 15, 2024
View reviewed changes
Copy link

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Since we want to move to to-device based mechanism soon-ish we don't need to over eng this for now

AndrewFerr
AndrewFerr approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I posted an optional code optimization, but LGTM overall

src/matrixrtc/MatrixRTCSessionManager.ts Outdated Show resolved Hide resolved
@hughns @AndrewFerr
Suggestion from code review
28df07b 
Co-authored-by: Andrew Ferrazzutti <[email protected]>
@hughns hughns enabled auto-merge August 19, 2024 13:31
@hughns hughns added this pull request to the merge queue Aug 19, 2024
Merged via the queue into develop with commit c408c0d Aug 19, 2024
26 checks passed
@hughns hughns deleted the hughns/rtc-decryption-retry branch August 19, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkwp fkwp fkwp approved these changes

@AndrewFerr AndrewFerr AndrewFerr approved these changes

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hughns @AndrewFerr @fkwp