Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resend MatrixRTC encryption keys if a membership has changed #4343

Merged
merged 6 commits into from
Aug 14, 2024
Merged

Resend MatrixRTC encryption keys if a membership has changed #4343

merged 6 commits into from
Aug 14, 2024

Conversation

hughns
Copy link
Member

@hughns hughns commented Aug 9, 2024 •
edited
Loading

This fixes element-hq/element-call#2415 by having call participants proactively sending a new io.element.call.encryption_keys room event with the same key if they detect that another participants has updated the membershipID or created_ts part of their call membership.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@hughns hughns added the T-Defect label Aug 9, 2024
@hughns hughns mentioned this pull request Aug 9, 2024
Closed
@hughns hughns requested a review from toger5 August 9, 2024 10:27
@hughns hughns marked this pull request as ready for review August 9, 2024 10:27
@hughns hughns requested a review from a team as a code owner August 9, 2024 10:27
fkwp
fkwp approved these changes Aug 9, 2024
View reviewed changes
Copy link

@fkwp fkwp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hughns hughns requested a review from AndrewFerr August 9, 2024 11:22
AndrewFerr
AndrewFerr reviewed Aug 9, 2024
View reviewed changes
src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
src/matrixrtc/MatrixRTCSession.ts Show resolved Hide resolved
@hughns
Always store latest fingerprints
7a97b80 
Should reduce unnecessary retransmits
@hughns hughns requested a review from AndrewFerr August 9, 2024 15:20
AndrewFerr
AndrewFerr approved these changes Aug 9, 2024
View reviewed changes
src/matrixrtc/MatrixRTCSession.ts Outdated Show resolved Hide resolved
@hughns hughns added this pull request to the merge queue Aug 14, 2024
Merged via the queue into develop with commit c65ef03 Aug 14, 2024
26 checks passed
@hughns hughns deleted the hughns/rtc-resend-keys-on-membership-updates branch August 14, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkwp fkwp fkwp approved these changes

@AndrewFerr AndrewFerr AndrewFerr approved these changes

@toger5 toger5 Awaiting requested review from toger5

Assignees
No one assigned
Labels
T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sender key distribution unreliable when running in embedded mode
3 participants
@hughns @AndrewFerr @fkwp