Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-legacy calls if any are found #4337

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

AndrewFerr
Copy link
Member

Akin to how legacy call events should be sent in rooms where there is any ongoing legacy call, send non-legacy events in rooms where there are only non-legacy calls; else fall back to the config preference.

Signed-off-by: Andrew Ferrazzutti [email protected]

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@AndrewFerr AndrewFerr added this pull request to the merge queue Aug 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 7, 2024
* Use non-legacy calls if any are found

Akin to how legacy call events should be sent in rooms where there is
any ongoing legacy call, send non-legacy events in rooms where there are
only non-legacy calls; else fall back to the config preference.

* Fix and rename

* Ignore non-ongoing legacy calls

* Fix and rename again
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 7, 2024
Akin to how legacy call events should be sent in rooms where there is
any ongoing legacy call, send non-legacy events in rooms where there are
only non-legacy calls; else fall back to the config preference.
@AndrewFerr AndrewFerr added this pull request to the merge queue Aug 7, 2024
@AndrewFerr AndrewFerr removed this pull request from the merge queue due to a manual request Aug 7, 2024
@AndrewFerr AndrewFerr force-pushed the af/rtc-session-type-detection branch from a93754f to f2771e2 Compare August 7, 2024 15:40
@AndrewFerr AndrewFerr enabled auto-merge August 7, 2024 15:40
@AndrewFerr AndrewFerr added this pull request to the merge queue Aug 7, 2024
Merged via the queue into develop with commit 9176d3a Aug 7, 2024
26 checks passed
@AndrewFerr AndrewFerr deleted the af/rtc-session-type-detection branch August 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants