Fix hashed ID server lookups with no Olm #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It used the hash function from Olm (presumably to work cross-platform) but subtle crypto is available on node nowadays so we can just use that. Refactor existing code that did this out to a common function, add tests.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
richvdh
reviewed
Jul 30, 2024
richvdh
reviewed
Jul 30, 2024
richvdh
reviewed
Jul 30, 2024
richvdh
reviewed
Jul 31, 2024
spec/unit/crypto/digest.spec.ts
Outdated
There was a problem hiding this comment.
move this out of crypto too, please.
richvdh
reviewed
Jul 31, 2024
richvdh
reviewed
Jul 31, 2024
|
I don't know why the sonarcloud results aren't coming through now :/ |
richvdh
reviewed
Jul 31, 2024
richvdh
approved these changes
Jul 31, 2024
| */ | ||
|
|
||
| /** | ||
| * @param plaintext The string to hash |
There was a problem hiding this comment.
I'd sort of assumed this was described completely by the @return param, but I can add a body too
t3chguy
approved these changes
Jul 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used the hash function from Olm (presumably to work cross-platform) but subtle crypto is available on node nowadays so we can just use that.
Refactor existing code that did this out to a common function, add tests.
Checklist
public/exportedsymbols have accurate TSDoc documentation.