Remove the compare function from utils #4315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and change the one use of it to just intantiate a collator and use it. This was marked as internal module so this shouldn't be a breaking change. Of course, react-sdk was using it. Requires: matrix-org/matrix-react-sdk#12782
otherwise we aren't testing anything different
|
New test passes in somewhere around 80ms on my machine, same as with the old code, so instantiating another collator for each sort operation doesn't appear to materially affect things. |
|
@dbkr worth testing in browsers, given that is where the performance issue was |
|
Tested on my big(ish) test account - no measurable difference between develop and this PR. |
t3chguy
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and change the one use of it to just intantiate a collator and use it.
This was marked as internal module so this shouldn't be a breaking change. Of course, react-sdk was using it.
Requires: matrix-org/matrix-react-sdk#12782
Checklist
public/exportedsymbols have accurate TSDoc documentation.