Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fetching the well known in embedded mode. #4259

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Add fetching the well known in embedded mode. #4259

merged 3 commits into from
Jun 26, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Jun 19, 2024 •
edited
Loading

This is used to load the focus from the well known in elment-call.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

@toger5 toger5 requested review from a team as code owners June 19, 2024 12:55
@toger5 toger5 requested review from dbkr and robintown June 19, 2024 12:55
@toger5 toger5 force-pushed the toger5/add-well-known-fetching-to-embedded-mode branch from 28a59cd to 5c0e719 Compare June 19, 2024 14:54
@toger5
Add fetching the well known in embedded mode.
c4656c7 
This is used to load the focus from the well known in elment-call.
@toger5 toger5 force-pushed the toger5/add-well-known-fetching-to-embedded-mode branch from 5c0e719 to c4656c7 Compare June 19, 2024 15:05
@dbkr
Copy link
Member

dbkr commented Jun 19, 2024

Unassigning myself for now as it looks like this is still in-progress and getting (force) pushes.

@dbkr dbkr removed their request for review June 19, 2024 15:06
@toger5
Copy link
Contributor Author

toger5 commented Jun 20, 2024 •
edited
Loading

Unassigning myself for now as it looks like this is still in-progress and getting (force) pushes.

@dbkr
sorry for the force push.

Now it is ready to review.

We removed unrelated changes.

@toger5 toger5 requested a review from AndrewFerr June 21, 2024 10:09
AndrewFerr
AndrewFerr reviewed Jun 21, 2024
View reviewed changes
@toger5 @AndrewFerr
Update src/client.ts
79098b9 
Co-authored-by: Andrew Ferrazzutti <[email protected]>
dbkr
dbkr approved these changes Jun 26, 2024
View reviewed changes
@toger5 toger5 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit 0210106 Jun 26, 2024
27 checks passed
@toger5 toger5 deleted the toger5/add-well-known-fetching-to-embedded-mode branch June 26, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@AndrewFerr AndrewFerr AndrewFerr approved these changes

@robintown robintown Awaiting requested review from robintown robintown is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toger5 @dbkr @AndrewFerr