-
-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helpers for authenticated media, and associated documentation #4185
Conversation
@@ -21,6 +21,10 @@ endpoints from before Matrix 1.1, for example. | |||
|
|||
# Quickstart | |||
|
|||
> [!IMPORTANT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the reviewer - I think this our first usage of the blockquote styles provided by github. See https://github.com/orgs/community/discussions/16925 for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will we manage the second transition from unstable to stable?
Ah, sorry, it's mentioned briefly in the README diff here and in the depths of element-hq/element-web#27326 (comment) somewhere - we'd be introducing a breaking change later (once the MSC is either stable or released) which only returns authenticated media URLs. I'm not sure there's much of a way to avoid a breaking change here, given we'd want the js-sdk to produce authentication-required URLs by default as soon as it possibly can. |
Fair enough, as long as there's a plan for managing the second transition (ie. to stable) as well. |
Checklist
public
/exported
symbols have accurate TSDoc documentation.